Port of single scattering radar of ARTS2#1110
Draft
riclarsson wants to merge 3 commits intoatmtools:mainfrom
Draft
Port of single scattering radar of ARTS2#1110riclarsson wants to merge 3 commits intoatmtools:mainfrom
riclarsson wants to merge 3 commits intoatmtools:mainfrom
Conversation
Contributor
Author
|
@m-brath I need your help reviewing the scattering implementation to ensure it is in line with your understanding of how the new system should work. @erikssonpatrick I need your help to understand whether or not the radar tests and implementation comply with your understanding from ARTS2. Generally, I am also a bit unhappy with how many WSVs were added, but I do not have the experience required with radar stuff to make a class of this I am happy with (i.e., a RadarSensor class). |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a port of single scattering radar from ARTS2 to ARTS3.
It is entirely AI-guided. So I cannot merge this without review from @erikssonpatrick and @m-brath .
There are two parts to this PR:
Anyways, this needs a proper review because I am not sure how to test the radar other than trying to recreate the test in ARTS2, and I am not sure that that has been done correctly.