Skip to content

Added provision to pass misc flags to cmake #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nidish96 wants to merge 11 commits into
base: master
Choose a base branch
from
+11 −1
Open

Added provision to pass misc flags to cmake #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f0a6c7e
Added provision to pass misc flags to cmake
Nidish96 Feb 12, 2017
2c34155
Added provision to pass misc flags to cmake
Nidish96 Feb 12, 2017
e493d8e
Merge remote-tracking branch 'origin/nidish' into nidish
Nidish96 Feb 12, 2017
a189fed
Merge remote-tracking branch 'origin/nidish' into nidish
Nidish96 Feb 12, 2017
078d80d
Merge branch 'nidish' of https://github.com/Nidish96/cmake-ide into n…
Nidish96 Feb 12, 2017
daa3dcf
screwed up some pull-requests
Nidish96 Feb 12, 2017
87f361a
screwed up some merges
Nidish96 Feb 12, 2017
54f2b0f
Merge branch 'nidish' of https://github.com/Nidish96/cmake-ide into n…
Nidish96 Feb 12, 2017
4437823
minor commit
Nidish96 Mar 7, 2017
361f95d
Merge pull request #1 from atilaneves/master
Nidish96 Mar 30, 2017
687ca13
Merge branch 'master' into nidish
Nidish96 Mar 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions TODO.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
* Include C++ include dirs code
* Ensure compile commands directories do not duplicate
11 changes: 10 additions & 1 deletion cmake-ide.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,12 @@
:group 'cmake-ide
:safe #'stringp)

(defcustom cmake-ide-cmake-command-flags

@myrgy myrgy Jul 2, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just test comment

nil
"List of misc flags passed to the cmake invocation."
:group 'cmake-ide
:safe #'stringp)

@atilaneves atilaneves Feb 13, 2017

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a list of strings, no?

@dlyr dlyr Jul 4, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I have done something similar, and a string seems fine, you can set it to a bunch of option (like -DCMAKE_BUILD_TYPE=Debug -DOtherUsefullDef"
Then, I set it to "-DCMAKE_BUILD_TYPE=Debug" by default and use it to define the build directory.

@Nidish96 Nidish96 Jul 4, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad - it should be listp


(defcustom cmake-ide-header-search-other-file
t
"Whether or not to search for a corresponding source file for headers when setting flags for them."
Expand Down Expand Up @@ -559,7 +565,9 @@ the object file's name just above."
(when project-dir
(let ((default-directory cmake-dir))
(cmake-ide--message "Running cmake for src path %s in build path %s" project-dir cmake-dir)
(start-process "cmake" "*cmake*" cmake-ide-cmake-command "-DCMAKE_EXPORT_COMPILE_COMMANDS=ON" project-dir))))
(apply #'start-process "cmake" "*cmake*" cmake-ide-cmake-command project-dir
"-DCMAKE_EXPORT_COMPILE_COMMANDS=ON" cmake-ide-cmake-command-flags)
)))


(defun cmake-ide--get-build-dir ()
Expand Down Expand Up @@ -944,6 +952,7 @@ the object file's name just above."
(cmake-ide--message "Starting rdm server")
(with-current-buffer buf (start-process "rdm" (current-buffer)
cmake-ide-rdm-executable
"-j 2" "-i 40" "-a 10"

@atilaneves atilaneves Mar 31, 2017

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@Nidish96 Nidish96 Jul 20, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just changed the number of jobs to 2 - you can use the previous configuration itself

@Nidish96 Nidish96 Jul 20, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just changed the number of jobs to 2 - you can use the previous configuration itself

@atilaneves atilaneves Jul 21, 2017

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, but why? This should be at least configureable.

@myrgy myrgy Jul 29, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think if we add this settings as cmake-ide-rdm-options?

@atilaneves atilaneves Jul 30, 2017

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@myrgy That makes sense.

"-c" cmake-ide-rdm-rc-path))))))

(defun cmake-ide--process-running-p (name)
Expand Down