-
-
Notifications
You must be signed in to change notification settings - Fork 424
New module to query Lowell Observatory astorbDB database #3203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
New module to query Lowell Observatory astorbDB database #3203
Conversation
query code only for now; tests not written yet
Fixing some codestyle issues in core.py
…b.com/hhsieh00/astroquery into 3129-add-lowell-astorbdb-query-module
fixing more codestyle issues in core.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and very useful in general. Some initial comments and questions to address while you continue testing.
Thanks @mkelley for the review. I haven't looked into it in any meaningful way yet, but I notice that there are a lot of comments on async stuff. We should remove/rework the template module as a lot has changed. E.g. there is a preference of supporting actual async/sync API and not just with the early template hackary. So I would suggest to so that, too, if the service support async, then opt into that with a keyword argument, but don't duplicate the methods with the decorator. or one PR that did the keyword approach: #3201 or the ESA modules also have a |
First complete draft of the astorbdb class including tests and documentation
removed get_raw_response lines, changed names of dynamical_family and escape_routes methods, changed OrderedDict output to regular dictionaries. Also re-ordered methods in alphabetical order. Other minor edits.
fixed dynamical_family and escape_route function names in documentation; also added astorbdb.rst to various toc files
I'm not sure why the checks didn't run. @hhsieh00 You might want to try to |
…orbdb-query-module
query code only for now; tests not written yet
Fixing some codestyle issues in core.py
fixing more codestyle issues in core.py
First complete draft of the astorbdb class including tests and documentation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3203 +/- ##
==========================================
+ Coverage 70.72% 70.83% +0.11%
==========================================
Files 232 235 +3
Lines 20041 20310 +269
==========================================
+ Hits 14174 14387 +213
- Misses 5867 5923 +56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
removed get_raw_response lines, changed names of dynamical_family and escape_routes methods, changed OrderedDict output to regular dictionaries. Also re-ordered methods in alphabetical order. Other minor edits.
fixed dynamical_family and escape_route function names in documentation; also added astorbdb.rst to various toc files
query code only for now; tests not written yet
Fixing some codestyle issues in core.py
fixing more codestyle issues in core.py
First complete draft of the astorbdb class including tests and documentation
removed get_raw_response lines, changed names of dynamical_family and escape_routes methods, changed OrderedDict output to regular dictionaries. Also re-ordered methods in alphabetical order. Other minor edits.
…b.com/hhsieh00/astroquery into 3129-add-lowell-astorbdb-query-module
This is a new module for querying the Lowell Observatory astorbDB database (see issue #3129), specifically using REST APIs used to run their AstInfo tool (https://asteroid.lowell.edu/astinfo/). The AstInfo class in this module specifically retrieves designation, orbital element, orbit, albedo, color, taxonomy, lightcurve, dynamical family, and escape route data for asteroids catalogued in the Lowell astorbDB database.