Completely redesign the API around explicit strategies #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API is much nicer. Type families in the `Eval` type class were getting in the way of derivation (derivation isn't done yet). It just created a lot of boiler place. Both at call sites where we had to wrap random values in a newtype all the time, and when defining `Eval` instances (which may be used just once, which was entirely unnecessary), since the instances were almost entirely boilerplate. This actually deletes lines of code, so even the implementation is simpler really. I don't need some special support for the `strict-wrapper` library: just use the `seq` strategy. This is looking quite good. Closes #7. Closes #17.
This was referenced May 17, 2025
|
It seems to work well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API is much nicer. Type families in the
Evaltype class were getting in the way of derivation (derivation isn't done yet). It just created a lot of boiler place. Both at call sites where we had to wrap random values in a newtype all the time, and when definingEvalinstances (which may be used just once, which was entirely unnecessary), since the instances were almost entirely boilerplate.This actually deletes lines of code, so even the implementation is simpler really. I don't need some special support for the
strict-wrapperlibrary: just use theseqstrategy.This is looking quite good.
Closes #7.
Closes #17.