hack(venv_shim): Unset -E and translate -I to -s #705
+323
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python has an `-E` flag, which causes it to ignore PYTHONHOME and PYTHONEXECUTABLE both of which are key to how we're making the shim work. Add a flag parser to the shim so we process the argv and strip out -E if it's set, and if -I is set we translate it to its equivalent -E and -s, and drop the -E. Add Rust tests covering some basic cases for the parser so we aren't integration testing that. Update Clap. Go back to unwind rather than abort as our error handling strategy as it's required for writing tests and clap.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python has an
-Eflag, which causes it to ignore PYTHONHOME and PYTHONEXECUTABLE both of which are key to how we're making the shim work.Add a flag parser to the shim so we process the argv and strip out -E if it's set, and if -I is set we translate it to its equivalent -E and -s, and drop the -E.
Add Rust tests covering some basic cases for the parser so we aren't integration testing that.
Update Clap.
Go back to unwind rather than abort as our error handling strategy as it's required for writing tests and clap.
Fixes #703.
Changes are visible to end-users: no
py_venvwill now unset the-Einterpreter flag with which it's incompatible.-Iis translated to-s.Test plan