Skip to content

Conversation

@mutalibmohammed
Copy link

@mutalibmohammed mutalibmohammed commented Oct 28, 2025

This pull request updates how compiler flags are collected in the _get_compiler_args function. The change ensures that both copts and cxxopts attributes are included when gathering rule-specific flags.

  • Now, both copts and cxxopts attributes are combined and used as rule flags in the _get_compiler_args function in lint/clang_tidy.bzl.

@CLAassistant
Copy link

CLAassistant commented Oct 28, 2025

CLA assistant check
All committers have signed the CLA.

@aspect-workflows
Copy link

aspect-workflows bot commented Oct 28, 2025

Test

All tests were cache hits

5 tests (100.0%) were fully cached saving 2s.


Test

example

8 test targets passed

Targets
//tools/format:format_test_HTML_Jinja_with_djlint [k8-fastbuild]5s
//tools/format:format_test_JavaScript_with_prettier [k8-fastbuild]14s
//tools/format:format_test_Markdown_with_prettier [k8-fastbuild]4s
//tools/format:format_test_Protocol_Buffer_with_buf [k8-fastbuild]597ms
//tools/format:format_test_Python_with_ruff [k8-fastbuild]763ms
//tools/format:format_test_SQL_with_prettier [k8-fastbuild]3s
//tools/format:format_test_Scala_with_scalafmt [k8-fastbuild]6s
//tools/format:format_test_Starlark_with_buildifier [k8-fastbuild]236ms

Total test execution time was 32s. 33 tests (80.5%) were fully cached saving 14s.


Test (WORKSPACE) (Test)

example

8 test targets passed

Targets
//tools/format:format_test_HTML_Jinja_with_djlint [k8-fastbuild]1s
//tools/format:format_test_JavaScript_with_prettier [k8-fastbuild]5s
//tools/format:format_test_Markdown_with_prettier [k8-fastbuild]845ms
//tools/format:format_test_Protocol_Buffer_with_buf [k8-fastbuild]429ms
//tools/format:format_test_Python_with_ruff [k8-fastbuild]97ms
//tools/format:format_test_SQL_with_prettier [k8-fastbuild]1s
//tools/format:format_test_Scala_with_scalafmt [k8-fastbuild]3s
//tools/format:format_test_Starlark_with_buildifier [k8-fastbuild]143ms

Total test execution time was 12s. 13 tests (61.9%) were fully cached saving 8s.


Lint [.]      Lint [example]

@mutalibmohammed
Copy link
Author

@alexeagle Could I have a review for this please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants