Skip to content

Conversation

@evren-okcu
Copy link
Member

@race-of-sloths include

@evren-okcu evren-okcu requested a review from artob as a code owner April 14, 2025 07:09
@race-of-sloths
Copy link

race-of-sloths commented Apr 14, 2025

@evren-okcu Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
New Sloth joined the Race! Welcome!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: stale

This pull request was removed from the race, but you can include it again with @race-of-sloths include command

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@artob artob added the enhancement New feature or request label Apr 16, 2025
@artob
Copy link
Member

artob commented Apr 16, 2025

@SamuelSarle @imunproductive Kindly review this PR

@artob
Copy link
Member

artob commented Apr 16, 2025

@race-of-sloths score 13

Comment on lines 94 to 96
- name: macOS
target: x86_64-apple-darwin
os: macos-latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this either be or separately include arm apple?

path: |
~/.cargo/registry
~/.cargo/git
key: ${{ runner.os }}-cargo-registry-${{ hashFiles('**/Cargo.lock') }}
Copy link
Member

@SamuelSarle SamuelSarle Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lib packages usually don't include lock files while binaries do. Does it matter here? (hashFiles would always return the same, hash of zero files).

Some other project for example does this:

This cache is automatically keyed by:

  • ...
  • a hash of all Cargo.lock / Cargo.toml files found anywhere in the repository (if present).

Probably it'd make sense to do hashFiles('**/Cargo.toml', '**/Cargo.lock')?

There is the minor issue of cache hit/miss but also leads to:

  1. Possibly multiple actions incorrectly fighting over the same cache key where they restore from cache, don't see the relevant items and redownload, then overwrite the cache.
  2. The cache keeps growing whenever dependencies change in a project without Cargo.lock. The cache key always matches so it's restored, new items are added, and then the bigger cache is saved. Old cache items are never evicted.

@race-of-sloths
Copy link

❌ PR inactive

This PR has been inactive for two weeks. It's now marked as stale.

Tip

If you think it's a mistake, you can restart the bot with include command to proceed 🔄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants