Repository navigation
Ensure that a review (re)request against an already reviewed tip yields attention - #2
Merged
Merged
Conversation
…ds attention I left my self a review comment saying "come back to this, check with @x", and then went to the GH UI and clicked "request re-review" -- but as reviewq had (rightly) marked the sha as reviewed it didn't result in any attention marker. The fix here is to comare the date of when we marked last_reviwed_sha vs when the review request came in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I left my self a review comment saying "come back to this, check with @x", and
then went to the GH UI and clicked "request re-review" -- but as reviewq
had (rightly) marked the sha as reviewed it didn't result in any attention
marker.
The fix here is to comare the date of when we marked last_reviwed_sha vs when
the review request came in