Repository navigation
[ISSUE-213]: FIX bin/install reads the wrong asdf variables when python3 is a shim - #214
Merged
Rusydy merged 2 commits intoNov 14, 2026
Merged
Conversation
…ironment variable names
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Tip: Get a Slack DM when cubic finishes reviewing your PRs. Connect Slack
View guided diff | Re-trigger cubic
Contributor
Author
|
It will solve #213 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fixes
bin/installreading the wrong asdf variables whenpython3is a shim, which caused the plugin to resolve the wrong install version and path.bin/installentrypoint from Python to Bash so it delegates tolib/install.pywithout relying on thepython3shim environment.ASDF_PHP_INSTALL_VERSIONandASDF_PHP_INSTALL_PATHso they no longer collide with asdf'sASDF_INSTALL_VERSIONandASDF_INSTALL_PATHwhenpython3is an asdf-managed shim.python3shim to verify the wrapper passes the PHP variables through and forwards arguments.Written for commit 410c2b4. Summary will update on new commits.