Skip to content

[ISSUE-213]: FIX bin/install reads the wrong asdf variables when python3 is a shim - #214

Merged
Rusydy merged 2 commits into
asdf-community:masterfrom
Rusydy:fix/213-bin-install-shim-env
Nov 14, 2026
Merged

Rusydy merged 2 commits into
asdf-community:masterfrom
Rusydy:fix/213-bin-install-shim-env

Conversation

@Rusydy

@Rusydy Rusydy commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary by cubic

Fixes bin/install reading the wrong asdf variables when python3 is a shim, which caused the plugin to resolve the wrong install version and path.

  • Converts the bin/install entrypoint from Python to Bash so it delegates to lib/install.py without relying on the python3 shim environment.
  • Renames the consumed variables to ASDF_PHP_INSTALL_VERSION and ASDF_PHP_INSTALL_PATH so they no longer collide with asdf's ASDF_INSTALL_VERSION and ASDF_INSTALL_PATH when python3 is an asdf-managed shim.
  • Adds Bats tests that fake a python3 shim to verify the wrapper passes the PHP variables through and forwards arguments.

Written for commit 410c2b4. Summary will update on new commits.

View guided diff

@Rusydy
Rusydy requested a review from a team as a code owner November 14, 2026 18:12

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files

Tip: Get a Slack DM when cubic finishes reviewing your PRs. Connect Slack

View guided diff | Re-trigger cubic

Comment thread tests/test_install.py Resolved
@Rusydy Rusydy changed the title [ISSUE-213]: FIX bin/install reads the wrong asdf variables when python3 is a shim [ISSUE-213]: FIX bin/install reads the wrong asdf variables when python3 is a shim on #213 Nov 14, 2026
@Rusydy Rusydy changed the title [ISSUE-213]: FIX bin/install reads the wrong asdf variables when python3 is a shim on #213 [ISSUE-213]: FIX bin/install reads the wrong asdf variables when python3 is a shim Nov 14, 2026
@Rusydy

Rusydy commented Nov 14, 2026

Copy link
Copy Markdown
Contributor Author

It will solve #213

@Rusydy
Rusydy merged commit eadb74b into asdf-community:master Nov 14, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant