Record the logarithm gathering as fixed, in the section that said it was not - #924
Merged
Conversation
…was not Section 11 was written while the rule was still unsound and gave acceptance criteria for whoever took it. #922 met them, so the section now records what closed it rather than what was owed -- and section 8 no longer says boundcheck reports one disagreement, because it reports none. Three things kept rather than dropped, since they generalise past this rule. Withdrawing a rewrite can break termination and not merely coverage: the limit machinery expands logarithms and relied on the simplifier to gather them back, so the guarded rule hung the suite where it was expected to cost answers. The identity moves to where it is checkable rather than being deleted, which is #802's rule and section 3's third row. And withdrawing a rewrite has a cost in search that is invisible until something is timed -- stating the approach too narrowly left the answer correct and six times slower. Also the four placements it took to find where the identity had to be stated, each ruled out by measurement: a limit solver never fires, a rewrite in the limit pipeline is reached zero times, stating the approach around one Simplify leaves the rule reached 192 times with nothing to check against, and stating it only at the +oo-normalised entries is correct but slow. Issue: #721 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation only, following #922.
§11 of
SimplificationContract.mdwas written whileln(a) + ln(b) -> ln(a*b)was still unsound, and it ended with acceptance criteria for whoever took it on. #922 met them, so the section now records what closed it rather than what was owed. §8 no longer saysboundcheckreports one disagreement, because it reports none.Three things are kept rather than dropped, because they generalise past this rule:
It also records the four placements it took to find where the identity had to be stated, each ruled out by measurement rather than argument: a limit solver never fires, a rewrite in the limit pipeline is reached zero times, stating the approach around one
Simplifyleaves the rule reached 192 times with nothing to check against, and stating it only at the+oo-normalised entries is correct but slow.No code changed, so the suite is master's.