Skip to content

Conversation

@jicampos
Copy link
Contributor

@jicampos jicampos commented Jan 14, 2026

@jicampos jicampos requested a review from rrivera747 January 14, 2026 19:13
<< (activeUsers.size() ? activeUsers : "no active users") << __E__;
(*out) << "Type of dump: \t\t" << dumpType << __E__;
(*out) << "Time of dump: \t\t" << rawtime;
// TODO: Add below to JSON dump
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this TODO is done now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Info is already included in the dump. The comment is removed here 8a62cec

if(dumpType == "JSON all")
{
// Include in "active"
// (*out) << "\t\"Configuration Alias\": \t\t\t\"" << configurationAlias << "\",\n";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete these comments?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed here 21ef9ab


out << "\"VERSION\": \"" << version_.toString() << "\",\n";

// out << "\"VERSION\" : \"" << version_ << "\"\n";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed here 21ef9ab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📋 Triage

Development

Successfully merging this pull request may close these issues.

3 participants