-
Notifications
You must be signed in to change notification settings - Fork 5
Jcampos/new db schema #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
proposal to clean up json format
…pos/NewDBSchema
| << (activeUsers.size() ? activeUsers : "no active users") << __E__; | ||
| (*out) << "Type of dump: \t\t" << dumpType << __E__; | ||
| (*out) << "Time of dump: \t\t" << rawtime; | ||
| // TODO: Add below to JSON dump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this TODO is done now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Info is already included in the dump. The comment is removed here 8a62cec
| if(dumpType == "JSON all") | ||
| { | ||
| // Include in "active" | ||
| // (*out) << "\t\"Configuration Alias\": \t\t\t\"" << configurationAlias << "\",\n"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete these comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed here 21ef9ab
otsdaq/TableCore/TableView.cc
Outdated
|
|
||
| out << "\"VERSION\": \"" << version_.toString() << "\",\n"; | ||
|
|
||
| // out << "\"VERSION\" : \"" << version_ << "\"\n"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed here 21ef9ab
Part of art-daq/otsdaq-utilities#225 and Mu2e/otsdaq-mu2e#234