Skip to content

wifi: aic8800_sdio: fix Makefile Kconfig symbol - #546

Open
berringtoni36-commits wants to merge 1 commit into
armbian:rk-6.1-rkr7.2from
berringtoni36-commits:fix/aic8800-kconfig-gate
Open

wifi: aic8800_sdio: fix Makefile Kconfig symbol#546
berringtoni36-commits wants to merge 1 commit into
armbian:rk-6.1-rkr7.2from
berringtoni36-commits:fix/aic8800-kconfig-gate

Conversation

@berringtoni36-commits

Copy link
Copy Markdown

Summary

  • gate the aic8800_sdio directory with the symbol defined by its Kconfig
  • make the driver selectable and buildable through normal kernel configuration

Verification

  • git diff --check
  • scripts/checkpatch.pl --strict --no-tree drivers/net/wireless/Makefile
  • confirmed the Makefile and aic8800_sdio/Kconfig use CONFIG_AIC_WLAN_SUPPORT
  • full ARM64 kernel build and board test were not run

Fixes #455

@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: a8d4bc22-0522-4944-a39a-3e1c8f2144e5

📥 Commits

Reviewing files that changed from the base of the PR and between 5ef479b and 92442b6.

📒 Files selected for processing (1)
  • drivers/net/wireless/Makefile

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The wireless Makefile now builds the aic8800_sdio/ directory when CONFIG_AIC_WLAN_SUPPORT is enabled. This replaces the undefined CONFIG_SPARD_WLAN_SUPPORT symbol. No driver source files or public declarations changed.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 92442

The AIC8800 SDIO driver is now selected by its defined Kconfig option, allowing configured builds to include the driver as intended. No current-head merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the Makefile Kconfig symbol fix for the aic8800_sdio driver.
Description check ✅ Passed The description explains the symbol change, intended build behavior, verification, and testing limits.
Linked Issues check ✅ Passed The change directly resolves issue #455 by replacing the undefined CONFIG_SPARD_WLAN_SUPPORT reference with the Kconfig-defined CONFIG_AIC_WLAN_SUPPORT symbol.
Out of Scope Changes check ✅ Passed The pull request contains only the Makefile change required to resolve issue #455. No unrelated changes are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aic8800_sdio: driver never builds — Makefile references undefined CONFIG_SPARD_WLAN_SUPPORT

1 participant