fix(boolean): conditional_enforce_equal to honor conditional semantics #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashass1315
requested review from
Pratyush,
mmagician and
z-tech
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of Boolean::conditional_enforce_equal returned Unsatisfiable whenever both operands were constant and unequal and the condition was not Constant(false). This violated EqGadget’s contract, which requires the constraint to be vacuously true when the condition is false, and it also diverged from other implementations in the codebase (e.g., FpVar) that encode conditional equality as (a - b) * condition == 0. This patch changes the logic to treat condition == Constant(false) as a no-op, to only error when condition == Constant(true) and the constants are unequal, and otherwise to enforce (a - b) * condition == 0 even in constant-constant cases by emitting the appropriate ±1 linear combination. This aligns the Boolean implementation with EqGadget semantics and the established pattern across field and vector implementations.