Open
Conversation
makes changes to make data entries compatable with motmetrics version 1.2 for faster runtime
Contributor
|
Thanks for the PR, @ahuller3. I'll take a look! |
Contributor
|
Looks like there are a few type complaints by |
johnwlambert
reviewed
Aug 4, 2021
| path_datasets = glob.glob(os.path.join(path_dataset_root, "*")) | ||
| num_total_gt = 0 | ||
|
|
||
| path_counter = 0 |
Contributor
There was a problem hiding this comment.
it looks like we don't use this path_counter elsewhere, can we remove it?
Contributor
|
Could you update the requirements file as well, where the |
|
|
||
| if bbox[3] > 0 and in_distance_range_pose(np.zeros(3), center, d_min, d_max): | ||
| track_label_uuid = gt_data[i]["track_label_uuid"] | ||
| if gt_data[i]["track_label_uuid"] not in track_label_uuids: |
Contributor
There was a problem hiding this comment.
Hi Anna, could you add a brief inline comment here explaining the logic for what we are doing here?
| glob.glob(os.path.join(os.fspath(path_tracker_output), "per_sweep_annotations_amodal", "*")) | ||
| ) | ||
|
|
||
| all_uuids: Dict[str, int] = {} |
Contributor
There was a problem hiding this comment.
could we add a brief inline comment here explaining what the all_uuids dictionary is for?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reformats data (uuids from string to int) and deals with invalid distances to make compatible with motmetrics version 1.2 which significantly improves runtime