Threading and timeout fixes - #230
Merged
Merged
Conversation
withSolvers spawns `count` solver instances and checkSat/mapConcurrently distribute queries across them, but on the non-threaded RTS getNumProcessors returns 1: exactly one solver is spawned and every concurrent map runs sequentially, on any machine. Adding -threaded (with -N to size the RTS to the available cores) makes the existing parallelism effective.
equivCheck passed the raw --smttimeout value to Solvers.withSolvers, which expects seconds and multiplies by 1000 when building the solver's own limit flag. A documented 60000ms budget therefore became 60000s (16.6 hours): a hard query would hold its solver instance indefinitely instead of timing out, and with the pool effectively serialised the run appeared to hang. `act type` already treats the value as milliseconds, so convert here (rounding up so a sub-second value cannot become 0, which means no limit).
mijovic
changed the title
anjapetkovic
reviewed
Aug 7, 2026
anjapetkovic
left a comment
anjapetkovic
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. I can confirm that testing in combination with --numsolvers from #232 accelerates the solving when specified more solvers.
lefterislazar
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.