Skip to content

Do not set compute type - #511

Merged
PJ-Finlay merged 3 commits into
argosopentech:masterfrom
pierotofy:nocompute
Apr 4, 2026
Merged

Do not set compute type#511
PJ-Finlay merged 3 commits into
argosopentech:masterfrom
pierotofy:nocompute

Conversation

@pierotofy

@pierotofy pierotofy commented Feb 5, 2026

Copy link
Copy Markdown
Contributor

This PR fixed a problem introduced with 5a9ec1e which broke support for certain models (e.g. Spanish).

Ref: LibreTranslate/LibreTranslate#930

The root cause is a quirky behavior of ctranslate2 which I remember encountering in #369, whereby setting the compute_type explicitly would cause certain models to return garbage.

Removing the explicit compute_type override and letting ctranslate2 figure out the appropriate value fixes the problem and restores the behavior of v1.9.6.

[piero:~/Documents/argos-translate] [venv] master* ± ARGOS_DEBUG=1 ARGOS_CHUNK_TYPE=STANZA python test_trans.py
('get_installed_languages',)
('paragraphs:', ['Vamos'])
('apply_packaged_translation', 'Vamos')
('Splitting sentences using SBD Model: (es) StanzaSentencizer',)
('sentences', ['Vamos'])
('tokenized', [['Vamos']])
('translated_batches', [TranslationResult(hypotheses=[['mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@', 'mainstre@@']], scores=[-39.73262023925781], attention=[], logits=[])])
('value_hypotheses:', [('mainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstre@@', -39.73262023925781)])
('translated_paragraphs:', [[('mainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstre@@', -39.73262023925781)]])
('hypotheses_to_return:', [('mainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstre@@', -39.73262023925781)])
mainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstremainstre@@

[piero:~/Documents/argos-translate] [venv] master* ± git commit -a -m "Revert 5a9ec1e"
[master 13c2130] Revert 5a9ec1e
 2 files changed, 2 deletions(-)

 [piero:~/Documents/argos-translate] [venv] master(1)* ± ARGOS_DEBUG=1 ARGOS_CHUNK_TYPE=STANZA python test_trans.py
('get_installed_languages',)
('paragraphs:', ['Vamos'])
('apply_packaged_translation', 'Vamos')
('Splitting sentences using SBD Model: (es) StanzaSentencizer',)
('sentences', ['Vamos'])
('tokenized', [['Vamos']])
('translated_batches', [TranslationResult(hypotheses=[['Come', 'on', '.']], scores=[-0.7667394280433655], attention=[], logits=[])])
('value_hypotheses:', [('Come on.', -0.7667394280433655)])
('translated_paragraphs:', [[('Come on.', -0.7667394280433655)]])
('hypotheses_to_return:', [('Come on.', -0.7667394280433655)])
Come on.

@pierotofy

Copy link
Copy Markdown
Contributor Author

Edited to allow compute_type to be overriden, but don't set it if it's auto.

@PJ-Finlay
PJ-Finlay merged commit a9b7a8e into argosopentech:master Apr 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants