-
Notifications
You must be signed in to change notification settings - Fork 10
[bricks] model configuration - refactoring for list of variables #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
b148a6b
9ba96fc
6a472a2
a47f527
9cb16dc
4618231
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,3 +9,13 @@ requires_model: true | |
| model: glass-breaking | ||
| model_configuration_variables: | ||
| - EI_AUDIO_CLASSIFICATION_MODEL | ||
| variables: | ||
| - name: EI_AUDIO_CLASSIFICATION_MODEL | ||
| description: Path to the model file | ||
| private: true | ||
| - name: CUSTOM_MODEL_PATH | ||
| description: Path to the custom model directory | ||
| private: true | ||
| - name: BIND_ADDRESS | ||
| description: Bind address | ||
| private: true | ||
|
Comment on lines
+13
to
+21
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I honestly think we could just remove those variables. I would avoid to add the private concepts if it isn't needed
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not agree. Thsi are useful and the concept of private is useful. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you elaborate? Why are they useful? Those are set by the model, so I am not sure why they should be defined here. |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,3 +9,13 @@ requires_model: true | |
| model: mobilenet-image-classification | ||
| model_configuration_variables: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we could remove the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It was left intentionally after last meeting in which discussed this. |
||
| - EI_CLASSIFICATION_MODEL | ||
| variables: | ||
| - name: EI_CLASSIFICATION_MODEL | ||
| description: Path to the model file | ||
| private: true | ||
| - name: CUSTOM_MODEL_PATH | ||
| description: Path to the custom model directory | ||
| private: true | ||
| - name: BIND_ADDRESS | ||
| description: Bind address | ||
| private: true | ||
Uh oh!
There was an error while loading. Please reload this page.