Skip to content

allow setting pins and SPI interface. For most client work - #63

Open
sabas1080 wants to merge 4 commits into
arduino-libraries:masterfrom
ElectronicCats:set_pins
Open

allow setting pins and SPI interface. For most client work#63
sabas1080 wants to merge 4 commits into
arduino-libraries:masterfrom
ElectronicCats:set_pins

Conversation

@sabas1080

Copy link
Copy Markdown

Hi

A pullrequest to add the characteristics of choosing the pins of the nina module

Thanks

per1234
per1234 previously requested changes Jun 4, 2019
Comment thread src/utility/spi_drv.cpp Outdated
Comment thread src/utility/spi_drv.cpp Outdated
Comment thread src/utility/spi_drv.cpp Outdated
Comment thread src/utility/spi_drv.cpp Outdated
Comment thread src/utility/spi_drv.cpp Outdated
Comment thread src/utility/spi_drv.cpp Outdated
Comment thread src/utility/spi_drv.cpp Outdated
Comment thread src/utility/spi_drv.cpp Outdated
Comment thread src/utility/spi_drv.cpp Outdated
Comment thread src/utility/spi_drv.cpp Outdated
@per1234
per1234 self-requested a review June 4, 2019 01:23
@per1234
per1234 dismissed their stale review June 4, 2019 01:25

All requested changes have now been made.

@per1234
per1234 removed their request for review March 10, 2021 00:07
@CLAassistant

CLAassistant commented Apr 9, 2021

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ sabas1080
❌ ladyada
You have signed the CLA already but the status is still pending? Let us recheck it.

@JayToltTech

Copy link
Copy Markdown

Why did this not get integrated? Running into an issue with this lack of merge now, three years later :-(

@sabas1080
sabas1080 requested a review from per1234 January 19, 2022 15:00
@per1234
per1234 removed their request for review January 26, 2022 05:48
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: code Related to content of the project itself type: enhancement Proposed improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants