Removing default value assignment within connect function - #31
Closed
aentinger wants to merge 4 commits into
Closed
Conversation
aentinger
force-pushed
the
remove-default-parameter
branch
3 times, most recently
from
March 23, 2020 06:21
a769f13 to
947892a
Compare
aentinger
force-pushed
the
remove-default-parameter
branch
from
March 23, 2020 06:22
947892a to
3bbedad
Compare
…nnect function we need to provide two slightly different definitions dependending wether we compile for ESP8266 or Arduino
…ld to version 2.5.0
Contributor
Author
|
Closing this because the great @facchinm initiated a upgrade to the latest ESP8266 core within for Arduino Create. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is catching two things at once ...
2.5.0andconnectwith anIPAddressargument (as is done here).Drawback: This will break all sketches which have relied on the default parameter being set. (Note for the future: Default parameters are really dangerous).