Remove EmuDeviceType from axdevice_base and use axvmconfig instead#38
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Removes the locally defined EmuDeviceType and re-exports EmulatedDeviceType from the axvmconfig crate, updating documentation and dependencies accordingly.
- Removed
emu_type.rsand its references inlib.rs - Updated crate-level docs to note the migration
- Added
axvmconfigdependency inCargo.toml
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| axdevice_base/src/lib.rs | Updated docs and replaced local EmuDeviceType import with axvmconfig re-export |
| axdevice_base/src/emu_type.rs | Removed the local EmuDeviceType definition |
| axdevice_base/Cargo.toml | Added axvmconfig dependency |
Comments suppressed due to low confidence (2)
axdevice_base/src/lib.rs:11
- [nitpick] The note '(Already moved to
axvmconfigcrate.)' is not prefixed with a '-' and may not render correctly as part of the list; consider adding a leading '-' or indenting it under the previous bullet to maintain proper list formatting.
//! (Already moved to `axvmconfig` crate.)
axdevice_base/Cargo.toml:16
- Disabling default-features on
axvmconfigmay omit necessary features like serde derive forEmulatedDeviceType; ensure theserdefeature is enabled or addfeatures = ["serde"]to your dependency to prevent missing trait implementations.
axvmconfig = { git = "https://github.com/arceos-hypervisor/axvmconfig.git", default-features = false }
hky1999
approved these changes
Jul 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.