Skip to content

Remove EmuDeviceType from axdevice_base and use axvmconfig instead#38

Merged
aarkegz merged 1 commit into
mainfrom
remove_emu_dev_type
Jul 12, 2025
Merged

Remove EmuDeviceType from axdevice_base and use axvmconfig instead#38
aarkegz merged 1 commit into
mainfrom
remove_emu_dev_type

Conversation

@aarkegz

@aarkegz aarkegz commented Jul 12, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@aarkegz aarkegz requested review from Copilot and hky1999 July 12, 2025 09:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Removes the locally defined EmuDeviceType and re-exports EmulatedDeviceType from the axvmconfig crate, updating documentation and dependencies accordingly.

  • Removed emu_type.rs and its references in lib.rs
  • Updated crate-level docs to note the migration
  • Added axvmconfig dependency in Cargo.toml

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
axdevice_base/src/lib.rs Updated docs and replaced local EmuDeviceType import with axvmconfig re-export
axdevice_base/src/emu_type.rs Removed the local EmuDeviceType definition
axdevice_base/Cargo.toml Added axvmconfig dependency
Comments suppressed due to low confidence (2)

axdevice_base/src/lib.rs:11

  • [nitpick] The note '(Already moved to axvmconfig crate.)' is not prefixed with a '-' and may not render correctly as part of the list; consider adding a leading '-' or indenting it under the previous bullet to maintain proper list formatting.
//!   (Already moved to `axvmconfig` crate.)

axdevice_base/Cargo.toml:16

  • Disabling default-features on axvmconfig may omit necessary features like serde derive for EmulatedDeviceType; ensure the serde feature is enabled or add features = ["serde"] to your dependency to prevent missing trait implementations.
axvmconfig = { git = "https://github.com/arceos-hypervisor/axvmconfig.git", default-features = false }

@aarkegz aarkegz merged commit 09fe1c3 into main Jul 12, 2025
10 checks passed
@aarkegz aarkegz deleted the remove_emu_dev_type branch July 12, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants