Skip to content

Conversation

@crweiner
Copy link

@crweiner crweiner commented Oct 16, 2025

What does this PR do?

  1. Fixes the links from [Configure services](/docs/advanced/self-hosting/configuration) to [Configure services](/docs/advanced/self-hosting#configuration)
  2. Adds # Next steps section to the Coolify page, just like the Google Cloud, AWS, etc. pages
  3. Adds a Sites card to the Self Hosting page as something to enable after deployment.

Test Plan

  • Tested via pnpm run dev and browsing to:
    • http://localhost:[port]/docs/advanced/self-hosting
    • http://localhost:[port]/docs/advanced/self-hosting/platforms/aws
    • http://localhost:[port]/docs/advanced/self-hosting/platforms/azure
    • http://localhost:[port]/docs/advanced/self-hosting/platforms/coolify
    • http://localhost:[port]/docs/advanced/self-hosting/platforms/digital-ocean
    • http://localhost:[port]/docs/advanced/self-hosting/platforms/google-cloud

Related PRs and Issues

Closes Issue #2498

Have you read the Contributing Guidelines on issues?

Yes. I understand that I need to run pnpm run build to test the build process. On my machine, the build fails, but I'm not sure if this is a problem with my local machine, or a greater issue with the build process as as result of my changes. The pnpm run dev local server builds these pages properly on the fly.

<--- Last few GCs --->

[93145:0x120008000]   152724 ms: Mark-Compact 4039.3 (4103.0) -> 4037.3 (4102.5) MB, pooled: 1 MB, 549.00 / 0.00 ms  (average mu = 0.074, current mu = 0.005) allocation failure; scavenge might not succeed
[93145:0x120008000]   153288 ms: Mark-Compact 4039.4 (4103.0) -> 4037.4 (4102.5) MB, pooled: 1 MB, 561.83 / 0.00 ms  (average mu = 0.041, current mu = 0.005) allocation failure; scavenge might not succeed


<--- JS stacktrace --->

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
----- Native stack trace -----

 1: 0x104b6066c node::OOMErrorHandler(char const*, v8::OOMDetails const&) [/opt/homebrew/Cellar/node/23.6.0/bin/node]
 2: 0x104d08740 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, v8::OOMDetails const&) [/opt/homebrew/Cellar/node/23.6.0/bin/node]
 3: 0x104ec56f0 v8::internal::Heap::CallGCPrologueCallbacks(v8::GCType, v8::GCCallbackFlags, v8::internal::GCTracer::Scope::ScopeId) [/opt/homebrew/Cellar/node/23.6.0/bin/node]
 4: 0x104ecb188 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags)::$_1::operator()() const [/opt/homebrew/Cellar/node/23.6.0/bin/node]
 5: 0x104ec5a34 void heap::base::Stack::SetMarkerAndCallbackImpl<v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags)::$_1>(heap::base::Stack*, void*, void const*) [/opt/homebrew/Cellar/node/23.6.0/bin/node]
 6: 0x104a78028 PushAllRegistersAndIterateStack [/opt/homebrew/Cellar/node/23.6.0/bin/node]
 7: 0x104ec291c v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [/opt/homebrew/Cellar/node/23.6.0/bin/node]
 8: 0x104ebc364 v8::internal::HeapAllocator::AllocateRawWithLightRetrySlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [/opt/homebrew/Cellar/node/23.6.0/bin/node]
 9: 0x104ebcd2c v8::internal::HeapAllocator::AllocateRawWithRetryOrFailSlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [/opt/homebrew/Cellar/node/23.6.0/bin/node]
10: 0x104ea76d4 v8::internal::FactoryBase<v8::internal::Factory>::AllocateRawArray(int, v8::internal::AllocationType) [/opt/homebrew/Cellar/node/23.6.0/bin/node]
11: 0x104ea7868 v8::internal::FactoryBase<v8::internal::Factory>::NewFixedArrayWithFiller(v8::internal::Handle<v8::internal::Map>, int, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::AllocationType) [/opt/homebrew/Cellar/node/23.6.0/bin/node]
12: 0x1050bb4a0 v8::internal::OrderedHashTable<v8::internal::OrderedHashSet, 1>::Allocate(v8::internal::Isolate*, int, v8::internal::AllocationType) [/opt/homebrew/Cellar/node/23.6.0/bin/node]
13: 0x1050bb114 v8::internal::OrderedHashTable<v8::internal::OrderedHashSet, 1>::Rehash(v8::internal::Isolate*, v8::internal::Handle<v8::internal::OrderedHashSet>, int) [/opt/homebrew/Cellar/node/23.6.0/bin/node]
14: 0x105164a84 v8::internal::Runtime_SetGrow(int, unsigned long*, v8::internal::Isolate*) [/opt/homebrew/Cellar/node/23.6.0/bin/node]
15: 0x1049579f4 Builtins_CEntry_Return1_ArgvOnStack_NoBuiltinExit [/opt/homebrew/Cellar/node/23.6.0/bin/node]
16: 0x10493b674 Builtins_SetPrototypeAdd [/opt/homebrew/Cellar/node/23.6.0/bin/node]
17: 0x10d3cad0c 
18: 0x1048c0838 Builtins_InterpreterEntryTrampoline [/opt/homebrew/Cellar/node/23.6.0/bin/node]
19: 0x10d6d834c 
20: 0x1048fde20 Builtins_AsyncFunctionAwaitResolveClosure [/opt/homebrew/Cellar/node/23.6.0/bin/node]
21: 0x1049cb298 Builtins_PromiseFulfillReactionJob [/opt/homebrew/Cellar/node/23.6.0/bin/node]
22: 0x1048ed214 Builtins_RunMicrotasks [/opt/homebrew/Cellar/node/23.6.0/bin/node]
23: 0x1048be3f0 Builtins_JSRunMicrotasksEntry [/opt/homebrew/Cellar/node/23.6.0/bin/node]
24: 0x104e3a5dc v8::internal::(anonymous namespace)::Invoke(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) [/opt/homebrew/Cellar/node/23.6.0/bin/node]
25: 0x104e3ad48 v8::internal::(anonymous namespace)::InvokeWithTryCatch(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) [/opt/homebrew/Cellar/node/23.6.0/bin/node]
26: 0x104e652fc v8::internal::MicrotaskQueue::PerformCheckpointInternal(v8::Isolate*) [/opt/homebrew/Cellar/node/23.6.0/bin/node]
27: 0x104a795e4 node::InternalCallbackScope::Close() [/opt/homebrew/Cellar/node/23.6.0/bin/node]
28: 0x104a79444 node::InternalCallbackScope::~InternalCallbackScope() [/opt/homebrew/Cellar/node/23.6.0/bin/node]
29: 0x104a79414 node::CallbackScope::~CallbackScope() [/opt/homebrew/Cellar/node/23.6.0/bin/node]
30: 0x104b234ec (anonymous namespace)::uvimpl::Work::AfterThreadPoolWork(int) [/opt/homebrew/Cellar/node/23.6.0/bin/node]
31: 0x104b239f8 node::ThreadPoolWork::ScheduleWork()::'lambda'(uv_work_s*, int)::operator()(uv_work_s*, int) const [/opt/homebrew/Cellar/node/23.6.0/bin/node]
32: 0x104b238b0 node::ThreadPoolWork::ScheduleWork()::'lambda'(uv_work_s*, int)::__invoke(uv_work_s*, int) [/opt/homebrew/Cellar/node/23.6.0/bin/node]
33: 0x1081d6660 uv__work_done [/opt/homebrew/Cellar/libuv/1.49.2/lib/libuv.1.dylib]
34: 0x1081d9cf4 uv__async_io [/opt/homebrew/Cellar/libuv/1.49.2/lib/libuv.1.dylib]
35: 0x1081ea114 uv__io_poll [/opt/homebrew/Cellar/libuv/1.49.2/lib/libuv.1.dylib]
36: 0x1081da184 uv_run [/opt/homebrew/Cellar/libuv/1.49.2/lib/libuv.1.dylib]
37: 0x104a7a488 node::SpinEventLoopInternal(node::Environment*) [/opt/homebrew/Cellar/node/23.6.0/bin/node]
38: 0x104ba7dac node::NodeMainInstance::Run(node::ExitCode*, node::Environment*) [/opt/homebrew/Cellar/node/23.6.0/bin/node]
39: 0x104ba7b00 node::NodeMainInstance::Run() [/opt/homebrew/Cellar/node/23.6.0/bin/node]
40: 0x104b2089c node::Start(int, char**) [/opt/homebrew/Cellar/node/23.6.0/bin/node]
41: 0x18a28eb98 start [/usr/lib/dyld]
 ELIFECYCLE  Command failed.

Summary by CodeRabbit

Release Notes

  • Documentation
    • Added a new Sites configuration section to the self-hosting documentation
    • Updated navigation links across platform guides (AWS, Azure, DigitalOcean, Google Cloud) to reference in-page anchors
    • Added a Next steps section to the Coolify deployment guide with post-deployment resources

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 16, 2025

Walkthrough

This pull request updates documentation for the self-hosting guides. It adds a new "Sites" configuration card to the main self-hosting page, mirrors this in a new "Next steps" section within the Coolify platform guide, and updates navigation links across AWS, Azure, DigitalOcean, and Google Cloud platform guides. The link changes redirect from a standalone configuration page (/docs/advanced/self-hosting/configuration) to an in-page anchor (/docs/advanced/self-hosting#configuration).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

The changes consist primarily of homogeneous link updates applied consistently across multiple platform documentation files, plus straightforward content additions. All modifications are in Markdoc documentation files with no logic changes, control flow alterations, or complex structural refactoring involved.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "Update Self Hosting -> Configure service link and add Sites card" refers to two real, significant changes present in the pull request: the link updates from /docs/advanced/self-hosting/configuration to /docs/advanced/self-hosting#configuration across multiple platform pages, and the addition of a "Sites" card to the Self Hosting docs page. However, the title omits the third change—adding a "Next steps" section to the Coolify page. The title is clear, concise, and contains no misleading information, making it partially related to the changeset. Per the evaluation criteria, partially related titles that refer to real aspects of the change qualify as passing, and the instructions acknowledge that titles need not cover every detail of the changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 98d11fb and 4c0fa4a.

📒 Files selected for processing (6)
  • src/routes/docs/advanced/self-hosting/+page.markdoc (1 hunks)
  • src/routes/docs/advanced/self-hosting/platforms/aws/+page.markdoc (1 hunks)
  • src/routes/docs/advanced/self-hosting/platforms/azure/+page.markdoc (1 hunks)
  • src/routes/docs/advanced/self-hosting/platforms/coolify/+page.markdoc (1 hunks)
  • src/routes/docs/advanced/self-hosting/platforms/digitalocean/+page.markdoc (1 hunks)
  • src/routes/docs/advanced/self-hosting/platforms/google-cloud/+page.markdoc (1 hunks)
🔇 Additional comments (6)
src/routes/docs/advanced/self-hosting/platforms/google-cloud/+page.markdoc (1)

25-25: LGTM! Link correctly updated to in-page anchor.

The link update from /docs/advanced/self-hosting/configuration to /docs/advanced/self-hosting#configuration is correct and consistent with changes across other platform pages. The target anchor exists in the main self-hosting page.

src/routes/docs/advanced/self-hosting/platforms/aws/+page.markdoc (1)

57-57: LGTM! Consistent with other platform pages.

The link update correctly targets the in-page configuration anchor, maintaining consistency across all platform documentation.

src/routes/docs/advanced/self-hosting/platforms/azure/+page.markdoc (1)

25-25: LGTM! Link correctly updated.

The change aligns with the PR-wide pattern of redirecting configuration links to in-page anchors.

src/routes/docs/advanced/self-hosting/platforms/coolify/+page.markdoc (1)

81-87: LGTM! Excellent consistency improvement.

The addition of the "Next steps" section brings the Coolify page in line with the other platform documentation pages (AWS, Azure, DigitalOcean, Google Cloud), improving consistency across the documentation.

src/routes/docs/advanced/self-hosting/platforms/digitalocean/+page.markdoc (1)

44-44: LGTM! Final link update completes the consistency across all platforms.

The link update is correct and completes the consistent pattern of using in-page anchors for configuration references across all platform documentation pages.

src/routes/docs/advanced/self-hosting/+page.markdoc (1)

137-139: No issues found. The target Sites configuration page exists and is properly configured.

The new Sites card at lines 137-139 correctly links to the existing documentation page at /docs/advanced/self-hosting/configuration/sites. The target file is well-structured with valid frontmatter and comprehensive content covering site runtime configuration.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant