Skip to content

Conversation

@scottmarchant
Copy link
Contributor

@scottmarchant scottmarchant commented Jun 24, 2025

Change summary

Added swift wasm as a CI target, to help prevent future breakages to swift wasm builds in DataLoader

Details

  • Adds wasm build to pull_request and main, by adding references to new wasm build workflow from swiftlang.

Notes

PR Dependencies

The following PR's must be merged before this PR can be merged:

Testing done

Verified in separate fork that new workflow functions correctly:
https://github.com/PassiveLogic/swift-distributed-tracing/actions/runs/18858201101/job/53810934909?pr=2

@scottmarchant scottmarchant marked this pull request as ready for review June 24, 2025 19:17
@scottmarchant scottmarchant force-pushed the feat/add-swift-wasm-ci branch from 39cb93b to e4ff7da Compare July 28, 2025 19:45
@ktoso
Copy link
Member

ktoso commented Sep 25, 2025

Sorry I missed this back then, is this something you'd like to push forward @MaxDesiatov @scottmarchant ? Got a few moments on my hands so could help verify the CI runs

@FranzBusch
Copy link
Member

@scottmarchant can you resolve the conflicts on this PR?

@scottmarchant
Copy link
Contributor Author

@scottmarchant can you resolve the conflicts on this PR?

Yep, will do.

@scottmarchant scottmarchant force-pushed the feat/add-swift-wasm-ci branch from 4efb124 to 8696a41 Compare October 27, 2025 23:07
@scottmarchant
Copy link
Contributor Author

scottmarchant commented Oct 27, 2025

@FranzBusch Rebase done. And I updated the build workflow references to match some of the latest patterns being used in other repos.

I ran a pre-test of this change in our company's fork, and everything appears to be building and passing fine:

https://github.com/PassiveLogic/swift-distributed-tracing/actions/runs/18858201101/job/53810934909?pr=2

@slashmo slashmo added the semver/none No version bump required. label Oct 28, 2025
@czechboy0
Copy link
Contributor

Actually I wonder if we shouldn't use this flavor of the Wasm workflow, for consistency with all the other platforms: https://github.com/apple/swift-nio/blob/main/.github/workflows/wasm_swift_sdk.yml

@FranzBusch
Copy link
Member

Actually I wonder if we shouldn't use this flavor of the Wasm workflow, for consistency with all the other platforms: https://github.com/apple/swift-nio/blob/main/.github/workflows/wasm_swift_sdk.yml

Yes we should. Before your force push @scottmarchant you were using the NIO workflows. Can you please change back to them again.

@scottmarchant
Copy link
Contributor Author

Yes we should. Before your force push @scottmarchant you were using the NIO workflows. Can you please change back to them again.

@FranzBusch Done, switched to the nio wasm workflows. Below is a link to a test-run of the workflow

https://github.com/PassiveLogic/swift-distributed-tracing/actions/runs/18883992949/job/53894462951?pr=2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver/none No version bump required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants