-
Couldn't load subscription status.
- Fork 51
ci: Add swift wasm builds to CI to prevent future breakages to wasm builds #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
39cb93b to
e4ff7da
Compare
|
Sorry I missed this back then, is this something you'd like to push forward @MaxDesiatov @scottmarchant ? Got a few moments on my hands so could help verify the CI runs |
|
@scottmarchant can you resolve the conflicts on this PR? |
Yep, will do. |
4efb124 to
8696a41
Compare
|
@FranzBusch Rebase done. And I updated the build workflow references to match some of the latest patterns being used in other repos. I ran a pre-test of this change in our company's fork, and everything appears to be building and passing fine: |
|
Actually I wonder if we shouldn't use this flavor of the Wasm workflow, for consistency with all the other platforms: https://github.com/apple/swift-nio/blob/main/.github/workflows/wasm_swift_sdk.yml |
Yes we should. Before your force push @scottmarchant you were using the NIO workflows. Can you please change back to them again. |
@FranzBusch Done, switched to the nio wasm workflows. Below is a link to a test-run of the workflow |
Change summary
Added swift wasm as a CI target, to help prevent future breakages to swift wasm builds in DataLoader
Details
pull_requestandmain, by adding references to new wasm build workflow from swiftlang.Notes
PR Dependencies
The following PR's must be merged before this PR can be merged:
Testing done
Verified in separate fork that new workflow functions correctly:
https://github.com/PassiveLogic/swift-distributed-tracing/actions/runs/18858201101/job/53810934909?pr=2