Add filesystem notification (FSNotify) support #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realrajaryan
force-pushed
the
users/realrajaryan/fsnotify
branch
from
f89a058 to
128421e
Compare
realrajaryan
force-pushed
the
users/realrajaryan/fsnotify
branch
from
128421e to
816c698
Compare
jglogan
reviewed
Sep 17, 2025
jglogan
reviewed
Sep 17, 2025
jglogan
reviewed
Sep 17, 2025
Member
|
@realrajaryan Can you take a peek at the CI fail, it's for the new test added |
jglogan
reviewed
Sep 22, 2025
jglogan
requested changes
Sep 24, 2025
jglogan
reviewed
Sep 25, 2025
realrajaryan
force-pushed
the
users/realrajaryan/fsnotify
branch
4 times, most recently
from
b33caa9 to
07a7db3
Compare
jglogan
reviewed
Oct 2, 2025
dcantah
reviewed
Oct 2, 2025
jglogan
requested changes
Oct 2, 2025
Contributor
jglogan
left a comment
jglogan
left a comment
There was a problem hiding this comment.
Let's get the concurrency working so that it's not @unchecked. See Danny's suggestion about using NIO for the socket communication.
realrajaryan
force-pushed
the
users/realrajaryan/fsnotify
branch
from
11e1720 to
eb651c5
Compare
dcantah
reviewed
Oct 9, 2025
dcantah
reviewed
Oct 9, 2025
realrajaryan
force-pushed
the
users/realrajaryan/fsnotify
branch
from
a99b69b to
d7001e6
Compare
jglogan
reviewed
Oct 14, 2025
Contributor
jglogan
left a comment
jglogan
left a comment
There was a problem hiding this comment.
Initial comments - need to review about three more files...
| responseStream: GRPCAsyncResponseStreamWriter<Com_Apple_Containerization_Sandbox_V3_NotifyFileSystemEventResponse>, | ||
| context: GRPC.GRPCAsyncServerCallContext | ||
| ) async throws { | ||
| for try await request in requestStream { |
Contributor
There was a problem hiding this comment.
Maybe an optimization for later - read the stream into an array and send the entire batch to the worker?
Might be best to look at the end-to-end path at that point and work out what's most efficient.
jglogan
reviewed
Oct 14, 2025
jglogan
reviewed
Oct 14, 2025
realrajaryan
force-pushed
the
users/realrajaryan/fsnotify
branch
2 times, most recently
from
ce1df86 to
5070a02
Compare
realrajaryan
force-pushed
the
users/realrajaryan/fsnotify
branch
2 times, most recently
from
4c3353f to
d0e5314
Compare
…reading restrictions
…n vminitd runs as PID 1
…fix other comments
realrajaryan
force-pushed
the
users/realrajaryan/fsnotify
branch
from
863388c to
a55fe57
Compare
realrajaryan
force-pushed
the
users/realrajaryan/fsnotify
branch
from
a55fe57 to
4558603
Compare
jglogan
approved these changes
Nov 5, 2025
realrajaryan
added a commit
that referenced
this pull request
Nov 5, 2025
This reverts commit 80e84a9.
realrajaryan
added a commit
that referenced
this pull request
Nov 5, 2025
Reverts #294. This is causing the CI to break because of concurrency issues with tests. Let's revert while we investigate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses apple/container#141, where containers don't receive filesystem events on mounted volumes, preventing incremental rebuilds and other file-watching features. This PR implements the guest-side components for FSNotify. Host-side implementation in the container repo will complete the pipeline.
Summary:
cctl fsnotify) and integration test infrastructure