Fix focus #5086
Open
Fix focus #5086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omponent Seem useless sinces it adds isSuppressed during focus and remove it during unfocus.
ValJed
force-pushed
the
feature-layout-widget
branch
from
0336e98 to
eabad0e
Compare
stuartromanek
approved these changes
Oct 2, 2025
ValJed
commented
Oct 2, 2025
| handler(widget) { | ||
| if (widget.type !== '@apostrophecms/layout-column') { | ||
| this.renderContent(); | ||
| } |
There was a problem hiding this comment.
This fixes the issue of the rich text unfocusing because the entire area is re rendered through livre preview when typing (since before the rich text used it's own component without this mixin and now layout-widget and layout-column use this mixin with AposWidget).
I don't thing layout-widget and layout-column-widget should use AposWidget like regular widgets. I thing they should have their own basic componnent (like we did for quick image upload).
Let me know what you think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix layout widget focus not working when clicking on grid component.
Fix typing in rich text re rendering all widgets around and breaking focus
Put focus stuff in widget store because was a mess
What are the specific steps to test this change?
Bugs are fixed
What kind of change does this PR introduce?
Make sure the PR fulfills these requirements: