unified bt for modular#1020
Open
yodsv2 wants to merge 1 commit into
Open
Conversation
yodsv2
commented
Jun 5, 2026
| self._service_steps = list(steps) | ||
| self._service_trees = [ | ||
| (step_name, self._coerce_runtime_tree(subtree_or_builder)) | ||
| (step_name, BehaviorTree.resolve_tree(subtree_or_builder)) |
Contributor
Author
There was a problem hiding this comment.
It’s needed for ownership, not because that specific line is dramatically smarter.
self._coerce_runtime_tree(...) was BottingTree-owned coercion logic: “take a tree/node/builder and normalize it into a BehaviorTree.” But after the unification, that semantic belongs to BehaviorTree, not BottingTree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR unifies the modular JSON runtime path around BottingTree.
Modular is now only a JSON/data adapter: recipes compile into named planner steps, and BottingTree owns execution, progress, restart/pause behavior, services, and blackboard state.
Shared behavior tree composition/coercion now lives in BehaviorTree, with BT.Composite kept as compatibility delegation rather than a separate implementation.
It also removes the old modular runner/runtime facade, moves hero setup ownership into BottingTree, updates Modular Tester/Coder and campaign prebuilts to use the direct BottingTree path, and refreshes architecture validation/tests around the new contract.
Finally, it fixes the recent dialog flow issues by ensuring multi-dialog NPC interactions move/interact once, wait for the dialog to actually open, then send each dialog id in order.