fix(core): make skipNavigation request bookkeeping proxy-safe - #4099
Open
noahg9 wants to merge 2 commits into
Open
fix(core): make skipNavigation request bookkeeping proxy-safe#4099noahg9 wants to merge 2 commits into
noahg9 wants to merge 2 commits into
Conversation
skipNavigation wraps the request in a Proxy whose loadedUrl getter throws, so internal request-queue bookkeeping (zod, spread, JSON) tripped it — BasicCrawler worked around that by threading a separate unproxied request. The proxy now reports loadedUrl as non-enumerable, so bookkeeping skips it while direct access still throws. crawlingContext.request flows through unchanged and the duplicate parameter is gone. Closes apify#3526
noahg9
force-pushed
the
fix/unproxied-request-bookkeeping
branch
from
September 2, 2026 12:18
8e37c78 to
b404725
Compare
janbuchar
self-requested a review
September 2, 2026 13:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With skipNavigation, the request is wrapped in a Proxy whose loadedUrl getter throws. Internal request-queue bookkeeping reads the whole request and tripped that, so BasicCrawler worked around it by passing the original unproxied request as a separate argument.
The proxy now marks loadedUrl non-enumerable, so bookkeeping skips it while direct access still throws. That lets the normal request flow through, and the extra argument is removed.