feat(node): prolong individual request queue locks - #74
Open
atirna wants to merge 3 commits into
Open
Conversation
janbuchar
self-requested a review
August 31, 2026 19:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Crawlee can extend a request handler timeout, but the native filesystem queue currently has no way to extend the matching on-disk
orderNolock. A long handler can therefore outlive its reservation and be fetched by another shared consumer.This adds per-request prolongation at the native lock owner. The client records the exact lock value it wrote, extends that expiry, and returns
falseif the lock expired or another client has since reacquired the request. The Node binding exposes the method for the companion change in apify/crawlee#4041.Verification
cargo test(91 passed)npm test(60 passed)npm run lintnpm run fmt:checkRelated to apify/crawlee#3961.