-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[ZEPPELIN-6349] Bump Angular from 9 to 13 #5109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
659bc02
Upgrade Angular to v10 and remove uncompleted Helium v2
tbonelee 47c4b73
Remove unnecessary protracter
tbonelee 20594ba
Remove helium-vis-example code
tbonelee 749446f
Upgrade Angular (v10 -> v11)
tbonelee f5ecc6b
Upgrade Angular (v11 -> v12)
tbonelee 24038b5
Upgrade Angular (v12 -> v13)
tbonelee 2bfe1df
Fix styles
tbonelee f71f9ac
Add development configurations
tbonelee 55d9cab
Rollback monaco editor
tbonelee 6152475
Rename MessageDataTypeMap
tbonelee 1adc2fa
Rename unnecessary NODE_OPTION
tbonelee d0d9e69
Bump ansi_up from 4.0.4 to 6.0.6
tbonelee 7025272
Bump date-fns from 2.30.0 to 3.6.0
tbonelee b8f15cd
Bump dotenv from 8.6.0 to 17.2.3
tbonelee d8b385b
Bump lint-staged from 8.1.6 to 15.5.2
tbonelee 26c9415
Migrate tslint to eslint
tbonelee 49d63fa
Update exclusion rule in pom.xml to use `.browserslistrc`
tbonelee 7563ce7
Clarify type assertion in bindParagraph method
tbonelee 5c2c624
Fix formatting error
tbonelee 452e908
Fix missing EOF newline in .prettierignore
tbonelee f57c34a
Disable stylistic lint rules (Fix heap out of memory)
tbonelee 6086e50
Add import/no-cycle rule
tbonelee 25e8edf
Migrate eslint config to flat config
tbonelee dffa51f
Fix ESLint parserOptions.project path resolution with tsconfigRootDir
tbonelee aa0777d
Revert "Fix ESLint parserOptions.project path resolution with tsconfi…
tbonelee dd27805
Revert "Migrate eslint config to flat config"
tbonelee ab553fa
Reorganize TypeScript config files and use ESLint project: true
tbonelee e57e790
Remove `src/.browserslistrc` file\
tbonelee b4da5d3
Fix tsConfig path in angular.json
tbonelee bdfd8a5
Remove custom tslint related files
tbonelee 7b77cb7
Fix webpack LESS loader invalid dependency paths
tbonelee 0c8e7c2
Add path mapping for e2e/* in tsconfig.json
tbonelee e16bc7a
Remove unused eslint plugins
tbonelee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| { | ||
| "extends": ["prettier"], | ||
| "root": true, | ||
| "ignorePatterns": ["node_modules/**/*", "projects/**/*"], | ||
| "overrides": [ | ||
| { | ||
| "files": ["*.ts"], | ||
| "parserOptions": { | ||
| "project": true, | ||
| "createDefaultProgram": true | ||
| }, | ||
| "extends": [ | ||
| "plugin:@angular-eslint/ng-cli-compat", | ||
| "plugin:@angular-eslint/ng-cli-compat--formatting-add-on", | ||
| "plugin:@angular-eslint/template/process-inline-templates" | ||
| ], | ||
| "rules": { | ||
| "@angular-eslint/component-selector": [ | ||
| "error", | ||
| { | ||
| "type": ["element", "attribute"], | ||
| "prefix": ["zeppelin"], | ||
| "style": "kebab-case" | ||
| } | ||
| ], | ||
| "@angular-eslint/directive-selector": [ | ||
| "error", | ||
| { | ||
| "type": "attribute", | ||
| "prefix": ["zeppelin"], | ||
| "style": "kebab-case" | ||
| } | ||
| ], | ||
| "@angular-eslint/no-forward-ref": "off", | ||
| "@angular-eslint/prefer-output-readonly": "error", | ||
| "@typescript-eslint/adjacent-overload-signatures": "off", | ||
| "@typescript-eslint/array-type": "off", | ||
| "@typescript-eslint/ban-tslint-comment": "off", | ||
| "@typescript-eslint/class-literal-property-style": "off", | ||
| "@typescript-eslint/consistent-generic-constructors": "off", | ||
| "@typescript-eslint/consistent-indexed-object-style": "off", | ||
| "@typescript-eslint/consistent-type-assertions": "off", | ||
| "@typescript-eslint/consistent-type-definitions": "off", | ||
| "@typescript-eslint/no-confusing-non-null-assertion": "off", | ||
| "o-empty-function": "off", | ||
| "@typescript-eslint/no-empty-function": "off", | ||
| "@typescript-eslint/no-inferrable-types": "off", | ||
| "@typescript-eslint/prefer-for-of": "off", | ||
| "@typescript-eslint/prefer-function-type": "off", | ||
| "@typescript-eslint/member-delimiter-style": "off", | ||
| "@typescript-eslint/semi": "off", | ||
| "@typescript-eslint/type-annotation-spacing": "off", | ||
| "@typescript-eslint/ban-types": [ | ||
| "error", | ||
| { | ||
| "types": { | ||
| "Object": { | ||
| "message": "Use {} instead." | ||
| }, | ||
| "String": { | ||
| "message": "Use string instead." | ||
| }, | ||
| "Number": { | ||
| "message": "Use number instead." | ||
| }, | ||
| "Boolean": { | ||
| "message": "Use boolean instead." | ||
| }, | ||
| "Function": { | ||
| "message": "Use specific callable interface instead." | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "@typescript-eslint/member-ordering": "warn", | ||
| "@typescript-eslint/explicit-member-accessibility": [ | ||
| "off", | ||
| { | ||
| "accessibility": "explicit" | ||
| } | ||
| ], | ||
| "@typescript-eslint/no-explicit-any": "error", | ||
| "@typescript-eslint/no-floating-promises": "off", | ||
| "@typescript-eslint/no-for-in-array": "error", | ||
| "@typescript-eslint/naming-convention": "off", | ||
| "@typescript-eslint/no-non-null-assertion": "off", | ||
| "@typescript-eslint/no-this-alias": "error", | ||
| "@typescript-eslint/quotes": "off", | ||
| "eol-last": "off", | ||
| "import/no-cycle": "error", | ||
| "import/no-deprecated": "off", | ||
| "import/no-unassigned-import": "error", | ||
| "import/order": "error", | ||
| "jsdoc/newline-after-description": "off", | ||
| "max-len": "off", | ||
| "new-parens": "off", | ||
| "no-bitwise": "off", | ||
| "no-duplicate-imports": "error", | ||
| "no-invalid-this": "error", | ||
| "no-irregular-whitespace": "error", | ||
| "no-magic-numbers": "off", | ||
| "no-param-reassign": "error", | ||
| "no-redeclare": "error", | ||
| "no-sparse-arrays": "error", | ||
| "no-template-curly-in-string": "error", | ||
| "no-trailing-spaces": "off", | ||
| "no-underscore-dangle": "off", | ||
| "prefer-arrow/prefer-arrow-functions": "warn", | ||
| "prefer-object-spread": "error", | ||
| "prefer-template": "error", | ||
| "quote-props": "off", | ||
| "space-before-function-paren": "off", | ||
| "yoda": "error" | ||
| } | ||
| }, | ||
| { | ||
| "files": ["*.html"], | ||
| "extends": ["plugin:@angular-eslint/template/recommended"], | ||
| "rules": {} | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,3 +14,5 @@ coverage/* | |
| playwright-report/* | ||
| playwright-coverage/* | ||
| test-results/* | ||
|
|
||
| .angular/* | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "compilerOptions": { | ||
| "baseUrl": ".", | ||
| "paths": { | ||
| "e2e/*": ["./*"] | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that
.browserslistrcexists in bothzeppelin-web-angular/andzeppelin-web-angular/src/. Aside from comments, there doesn’t appear to be any difference between them. So I think it should be fine to keep just one of them.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed
src/.browserslistrc.