Skip to content

Conversation

@cchung100m
Copy link
Contributor

@cchung100m cchung100m commented Nov 26, 2025

Hi Reviewers,

This PR is trying to fix issues #17388. Any suggestions would be appreciated if you are available.

Root Cause:

The recovery functions assumed the vector size wouldn't change during the context's lifetime, but nested contexts would modify it. Each constraint context modifies the same additional_info_ vector in ConstIntBoundAnalyzer.

Solution:

  • Removed the strict ICHECK_EQ(additional_info_.size(), new_size) assertion
  • Modified the recovery function to simply resize back to the original size when the vector has grown

@cchung100m cchung100m changed the title [TIR] Fix tir.LowerIntrin check failed additional_info.size() == new_size (34 vs. 33) [TIR] Fix tir.LowerIntrin check failed additional_info.size() == new_size Nov 27, 2025
@cchung100m cchung100m marked this pull request as ready for review November 28, 2025 02:25
Copy link
Member

@tlopex tlopex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlopex tlopex merged commit 7fe8760 into apache:main Nov 28, 2025
13 checks passed
@cchung100m cchung100m deleted the issue-17388 branch November 28, 2025 06:34
@cchung100m
Copy link
Contributor Author

Thanks to @tlopex 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants