Skip to content

Conversation

@guan404ming
Copy link
Member

@guan404ming guan404ming commented Nov 21, 2025

How

  • Updat file patterns for specific linting hooks to ensure they only run on relevant file types.

minor update

  • Fix linting commands to handle interactive and non-interactive modes
  • Add 'pre-commit' to default stages in .pre-commit-config.yaml.
  • Add inplace fix flags

@guan404ming guan404ming marked this pull request as ready for review November 21, 2025 11:50
@guan404ming
Copy link
Member Author

cc @tqchen

Copy link
Contributor

@cchung100m cchung100m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks to @guan404ming 😄

@guan404ming
Copy link
Member Author

cc @tlopex

@tlopex
Copy link
Member

tlopex commented Nov 28, 2025

Do we really need this update for CI? cc @tqchen

@tqchen
Copy link
Member

tqchen commented Nov 28, 2025

I am not sure how it would impact ci since right now ci do not run pre-commit hooks, if it is generally helpful for people who use them then i think we can get it in, @guan404ming to confirm

@guan404ming
Copy link
Member Author

I am not sure how it would impact ci since right now ci do not run pre-commit hooks, if it is generally helpful for people who use them then i think we can get it in, @guan404ming to confirm

By updating file patterns to be more specific, hooks only scan relevant file types instead of checking every file. This reduces file processing and speeds up pre-commit execution in my local test.

While this PR currently focuses on the pre-commit, we can also evaluate the performance improvements to see if it's worth adopting in CI as well.

@tlopex tlopex merged commit c429a2b into apache:main Nov 30, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants