Fix import edge cases for DATE/TIMESTAMP, INT96, CSV quotes and format filtering#819
Open
gengziyand wants to merge 1 commit into
Open
Fix import edge cases for DATE/TIMESTAMP, INT96, CSV quotes and format filtering#819gengziyand wants to merge 1 commit into
gengziyand wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes several import edge cases in
java/tools:DATEandTIMESTAMPvalue conversion before writing Tablets, and pass import time precision fromTabletBuildertoValueConverter.INT96timestamps from nanos-of-day plus Julian day, and mark them as nanosecond precision inauto schema.
ZoneId, instead of using the JVM's currentDST offset.
--formatfiltering in directory mode respect file extensions, so unrelated files are skipped instead of parsedas data.
DATEandTIMESTAMPvectors through their actual vector classes.Tests