Repository navigation
fix(cpp): reject UTF-8 name collisions before CLI output - #1002
Merged
ColinLeeo merged 1 commit intoOct 10, 2026
Merged
Conversation
ColinLeeo
added a commit
that referenced
this pull request
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UTF-8 replacement can make distinct TsFile identifiers render as the same name. The CLI previously rejected only some NDJSON header collisions, returned exit code 3 for row queries, and could miss collisions in metadata, CSV/table output, or empty query results. Multi-object export could also create its destination before detecting a later object's collision.
This change makes name collisions consistently return exit code 2 before writing stdout or creating export files/directories:
ls,schema,count,stats,head,cat, andexport.--force.Follow-up for #997.
Validation:
./mvnw -o spotless:check -P with-cpppassed.git diff --checkpassed.