TINKERPOP-3217 Add server option to close Session automatically. #3284
+498
−383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiazcy
reviewed
Dec 2, 2025
...-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/session/SessionOpProcessor.java
Show resolved
Hide resolved
xiazcy
reviewed
Dec 2, 2025
...er/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinSessionReuseTxIntegrateTest.java
Outdated
Show resolved
Hide resolved
xiazcy
reviewed
Dec 2, 2025
...er/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinSessionReuseTxIntegrateTest.java
Outdated
Show resolved
Hide resolved
andreachild
reviewed
Dec 4, 2025
| if (destroySessionPostGraphOp) { | ||
| // Destroy the session after a successful rollback due to error. Placed here rather than | ||
| // in a finally block since we don't want to end the session if no commit/rollback succeeded. | ||
| session.manualKill(true); |
Contributor
There was a problem hiding this comment.
Since this is in a catch block that is catching all error types, is it possible for session.manualKill to be called twice if the previous call in the try block threw an error?
Contributor
Author
There was a problem hiding this comment.
This shouldn't happen, but even if it does, theres explicit handling in that method for that situation so it's safe to call it more than once.
andreachild
reviewed
Dec 4, 2025
...er/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinSessionReuseTxIntegrateTest.java
Outdated
Show resolved
Hide resolved
andreachild
reviewed
Dec 4, 2025
| /** | ||
| * Integration tests for gremlin-driver and bytecode sessions. | ||
| * | ||
| * NOTE: this is effectively a copy of GremlinSessionTxIntegrateTest but the expectation is that the gremlin-driver |
Contributor
There was a problem hiding this comment.
Is there a way to actually verify the connection is reused or the connection state such that it can be reused?
Contributor
Author
There was a problem hiding this comment.
There are server side metrics and/or logs that can be asserted against when a session is created/destroyed. This is a test that should be added but needs to wait on #3258
Cole-Greer
reviewed
Dec 5, 2025
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/Settings.java
Outdated
Show resolved
Hide resolved
Cole-Greer
reviewed
Dec 5, 2025
...er/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinSessionReuseTxIntegrateTest.java
Outdated
Show resolved
Hide resolved
Cole-Greer
reviewed
Dec 5, 2025
...er/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinSessionReuseTxIntegrateTest.java
Outdated
Show resolved
Hide resolved
The added destroySessionPostGraphOp setting enables re-using the same underlying connection for a different subsequent Session. This should increase performance for cases where many short-lived Transactions are sent to the server.
kenhuuu
force-pushed
the
TINKERPOP-3217
branch
from
0d65b6f to
7f7d9b8
Compare
Contributor
|
VOTE +1 |
1 similar comment
Contributor
|
VOTE +1 |
Contributor
|
Thank you, @kenhuuu, nice feature. Will port to our version too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The added destroySessionPostGraphOp setting enables re-using the same underlying connection for a different subsequent Session. This should increase performance for cases where many short-lived Transactions are sent to the server.
https://issues.apache.org/jira/browse/TINKERPOP-3217
VOTE +1