-
Notifications
You must be signed in to change notification settings - Fork 113
feat(gui): allow changing workflow access level #4161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
seongjinyoon
wants to merge
2
commits into
apache:main
Choose a base branch
from
seongjinyoon:feat/allow-workflow-access-level-change
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+80
−4
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,7 +20,7 @@ | |
| import { Component, EventEmitter, inject, OnDestroy, OnInit, Output } from "@angular/core"; | ||
| import { FormBuilder, FormControl, FormGroup, Validators } from "@angular/forms"; | ||
| import { ShareAccessService } from "../../../service/user/share-access/share-access.service"; | ||
| import { ShareAccess } from "../../../type/share-access.interface"; | ||
| import { Privilege, ShareAccess } from "../../../type/share-access.interface"; | ||
| import { UntilDestroy, untilDestroyed } from "@ngneat/until-destroy"; | ||
| import { UserService } from "../../../../common/service/user/user.service"; | ||
| import { GmailService } from "../../../../common/service/gmail/gmail.service"; | ||
|
|
@@ -76,6 +76,17 @@ export class ShareAccessComponent implements OnInit, OnDestroy { | |
| this.currentEmail = this.userService.getCurrentUser()?.email; | ||
| } | ||
|
|
||
| get hasWriteAccess(): boolean { | ||
| if (!this.currentEmail) { | ||
| return false; | ||
| } | ||
| if (this.currentEmail === this.owner) { | ||
| return true; | ||
| } | ||
| const currentUserAccess = this.accessList.find(entry => entry.email === this.currentEmail); | ||
| return currentUserAccess?.privilege === Privilege.WRITE; | ||
| } | ||
|
|
||
| ngOnInit(): void { | ||
| this.accessService | ||
| .getAccessList(this.type, this.id) | ||
|
|
@@ -238,6 +249,57 @@ export class ShareAccessComponent implements OnInit, OnDestroy { | |
| }); | ||
| } | ||
|
|
||
| public changeAccessLevel(email: string, newPrivilege: string): void { | ||
| const isOwnAccess = email === this.currentEmail; | ||
| const currentUserAccess = this.accessList.find(entry => entry.email === email); | ||
| const isDowngrade = currentUserAccess?.privilege === Privilege.WRITE && newPrivilege === "READ"; | ||
|
|
||
| if (isOwnAccess && isDowngrade) { | ||
| const modal: NzModalRef = this.modalService.create({ | ||
| nzTitle: "Downgrade Your Access", | ||
| nzContent: `Are you sure you want to change your own access to READ? You will no longer be able to edit this ${this.type} or manage access.`, | ||
| nzFooter: [ | ||
| { | ||
| label: "Cancel", | ||
| onClick: () => { | ||
| modal.close(); | ||
| this.ngOnInit(); | ||
| }, | ||
| }, | ||
| { | ||
| label: "Confirm", | ||
| type: "primary", | ||
| danger: true, | ||
| onClick: () => { | ||
| this.doChangeAccessLevel(email, newPrivilege); | ||
| modal.close(); | ||
| }, | ||
| }, | ||
| ], | ||
| }); | ||
| } else { | ||
| this.doChangeAccessLevel(email, newPrivilege); | ||
| } | ||
| } | ||
|
|
||
| private doChangeAccessLevel(email: string, newPrivilege: string): void { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The name is awkward. Consider something like |
||
| this.accessService | ||
| .grantAccess(this.type, this.id, email, newPrivilege) | ||
| .pipe(untilDestroyed(this)) | ||
| .subscribe({ | ||
| next: () => { | ||
| this.notificationService.success(`Access level for ${email} changed to ${newPrivilege}.`); | ||
| this.ngOnInit(); | ||
| }, | ||
| error: (error: unknown) => { | ||
| if (error instanceof HttpErrorResponse) { | ||
| this.notificationService.error(error.error.message); | ||
| } | ||
| this.ngOnInit(); | ||
| }, | ||
| }); | ||
| } | ||
|
|
||
| public verifyPublish(): void { | ||
| if (!this.isPublic) { | ||
| const modal: NzModalRef = this.modalService.create({ | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an existing
writeAccessvariable that is still used by other components. All other usages of the old variable should be replaced withhasWriteAccessto avoid stale states in other places.