Skip to content

#1662 - Migrate to Maven 4 #1716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

#1662 - Migrate to Maven 4 #1716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
23c5c0a
migrate to model version 4.1.0, remove explicit submodules, use paren…
mvolikas Nov 9, 2025
e5516d3
#1662 - update action to test with maven 4
mvolikas Nov 22, 2025
04327bf
Merge branch 'main' into feature-1662
mvolikas Nov 22, 2025
1797916
#1662 - test with maven-gh-actions-shared
mvolikas Nov 22, 2025
189041f
#1662 - separate workflow for maven 4
mvolikas Nov 22, 2025
f1f48d7
#1662 - build with maven 4 only
mvolikas Nov 22, 2025
2892e8c
#1662 - install maven 4 in the workflow
mvolikas Nov 22, 2025
677d51b
#1662 - fix subprojects for rc-5
mvolikas Nov 23, 2025
79b7193
#1662 - use uniform indentation format, use maven 4 in maven.yml work…
mvolikas Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion .github/workflows/maven.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,16 @@ jobs:
with:
distribution: adopt
java-version: 17
- name: Install Maven 4
Copy link
Contributor Author

@mvolikas mvolikas Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the easiest way I found to build with specific maven 4 versions. @rzo1 I think that the GitHub action you shared didn't work due to ASF restrictions on action repositories.

run: |
MAVEN_VERSION=4.0.0-rc-5
BASE_URL="https://dlcdn.apache.org/maven/maven-4/${MAVEN_VERSION}/binaries"
curl -fsSL "${BASE_URL}/apache-maven-${MAVEN_VERSION}-bin.tar.gz" -o maven.tar.gz
mkdir -p "$HOME/maven"
tar -xzf maven.tar.gz -C "$HOME/maven"
echo "M2_HOME=$HOME/maven/apache-maven-${MAVEN_VERSION}" >> "$GITHUB_ENV"
echo "$HOME/maven/apache-maven-${MAVEN_VERSION}/bin" >> "$GITHUB_PATH"
rm maven.tar.gz
- name: Build with Maven
run: mvn -B --no-transfer-progress -Prat -DskipTests verify -Dskip.format.code=false

Expand All @@ -63,5 +73,15 @@ jobs:
with:
distribution: adopt
java-version: ${{ matrix.java }}
- name: Install Maven 4
run: |
MAVEN_VERSION=4.0.0-rc-5
BASE_URL="https://dlcdn.apache.org/maven/maven-4/${MAVEN_VERSION}/binaries"
curl -fsSL "${BASE_URL}/apache-maven-${MAVEN_VERSION}-bin.tar.gz" -o maven.tar.gz
mkdir -p "$HOME/maven"
tar -xzf maven.tar.gz -C "$HOME/maven"
echo "M2_HOME=$HOME/maven/apache-maven-${MAVEN_VERSION}" >> "$GITHUB_ENV"
echo "$HOME/maven/apache-maven-${MAVEN_VERSION}/bin" >> "$GITHUB_PATH"
rm maven.tar.gz
- name: Build with Maven
run: mvn -B --no-transfer-progress package --file pom.xml -DCI_ENV=true verify
run: mvn -B --no-transfer-progress package --file pom.xml -DCI_ENV=true verify
99 changes: 48 additions & 51 deletions archetype/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,55 +19,52 @@ specific language governing permissions and limitations
under the License.
-->

<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.apache.stormcrawler</groupId>
<artifactId>stormcrawler</artifactId>
<version>3.5.1-SNAPSHOT</version>
</parent>
<artifactId>stormcrawler-archetype</artifactId>
<name>stormcrawler-archetype</name>
<build>
<resources>
<resource>
<directory>src/main/resources</directory>
<filtering>true</filtering>
<includes>
<include>archetype-resources/pom.xml</include>
<include>archetype-resources/crawler-conf.yaml</include>
</includes>
</resource>
<resource>
<directory>src/main/resources</directory>
<filtering>false</filtering>
<excludes>
<exclude>archetype-resources/pom.xml</exclude>
</excludes>
</resource>
</resources>
<extensions>
<extension>
<groupId>org.apache.maven.archetype</groupId>
<artifactId>archetype-packaging</artifactId>
<version>3.4.1</version>
</extension>
</extensions>
<pluginManagement>
<plugins>
<plugin>
<artifactId>maven-archetype-plugin</artifactId>
<version>3.4.1</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-resources-plugin</artifactId>
<version>3.3.1</version>
<configuration>
<escapeString>\</escapeString>
</configuration>
</plugin>
</plugins>
</pluginManagement>
</build>
<project xmlns="http://maven.apache.org/POM/4.1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 https://maven.apache.org/xsd/maven-4.1.0.xsd">

<parent/>

<artifactId>stormcrawler-archetype</artifactId>
<name>stormcrawler-archetype</name>
<build>
<resources>
<resource>
<directory>src/main/resources</directory>
<filtering>true</filtering>
<includes>
<include>archetype-resources/pom.xml</include>
<include>archetype-resources/crawler-conf.yaml</include>
</includes>
</resource>
<resource>
<directory>src/main/resources</directory>
<filtering>false</filtering>
<excludes>
<exclude>archetype-resources/pom.xml</exclude>
</excludes>
</resource>
</resources>
<extensions>
<extension>
<groupId>org.apache.maven.archetype</groupId>
<artifactId>archetype-packaging</artifactId>
<version>3.4.1</version>
</extension>
</extensions>
<pluginManagement>
<plugins>
<plugin>
<artifactId>maven-archetype-plugin</artifactId>
<version>3.4.1</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-resources-plugin</artifactId>
<version>3.3.1</version>
<configuration>
<escapeString>\</escapeString>
</configuration>
</plugin>
</plugins>
</pluginManagement>
</build>
</project>
11 changes: 3 additions & 8 deletions core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,9 @@ specific language governing permissions and limitations
under the License.
-->

<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>org.apache.stormcrawler</groupId>
<artifactId>stormcrawler</artifactId>
<version>3.5.1-SNAPSHOT</version>
</parent>
<project xmlns="http://maven.apache.org/POM/4.1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 https://maven.apache.org/xsd/maven-4.1.0.xsd">

<parent/>

<artifactId>stormcrawler-core</artifactId>
<packaging>jar</packaging>
Expand Down
72 changes: 33 additions & 39 deletions external/ai/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,44 +19,38 @@ specific language governing permissions and limitations
under the License.
-->

<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.apache.stormcrawler</groupId>
<artifactId>stormcrawler-external</artifactId>
<version>3.5.1-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>


<artifactId>stormcrawler-ai</artifactId>
<name>stormcrawler-ai</name>

<url>https://github.com/apache/stormcrawler/tree/master/external/ai</url>
<description>AI resources for StormCrawler</description>

<properties>
<langchain4j.version>1.8.0</langchain4j.version>
<langchain4j.openai.version>1.8.0</langchain4j.openai.version>
</properties>

<dependencies>
<dependency>
<groupId>dev.langchain4j</groupId>
<artifactId>langchain4j</artifactId>
<version>${langchain4j.version}</version>
<exclusions>
<exclusion>
<groupId>org.apache.opennlp</groupId>
<artifactId>opennlp-tools</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>dev.langchain4j</groupId>
<artifactId>langchain4j-open-ai</artifactId>
<version>${langchain4j.openai.version}</version>
</dependency>
</dependencies>
<project xmlns="http://maven.apache.org/POM/4.1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 https://maven.apache.org/xsd/maven-4.1.0.xsd">

<parent/>

<artifactId>stormcrawler-ai</artifactId>
<name>stormcrawler-ai</name>

<url>https://github.com/apache/stormcrawler/tree/master/external/ai</url>
<description>AI resources for StormCrawler</description>

<properties>
<langchain4j.version>1.8.0</langchain4j.version>
<langchain4j.openai.version>1.8.0</langchain4j.openai.version>
</properties>

<dependencies>
<dependency>
<groupId>dev.langchain4j</groupId>
<artifactId>langchain4j</artifactId>
<version>${langchain4j.version}</version>
<exclusions>
<exclusion>
<groupId>org.apache.opennlp</groupId>
<artifactId>opennlp-tools</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>dev.langchain4j</groupId>
<artifactId>langchain4j-open-ai</artifactId>
<version>${langchain4j.openai.version}</version>
</dependency>
</dependencies>

</project>
12 changes: 3 additions & 9 deletions external/aws/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,9 @@ specific language governing permissions and limitations
under the License.
-->

<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>org.apache.stormcrawler</groupId>
<artifactId>stormcrawler-external</artifactId>
<version>3.5.1-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>
<project xmlns="http://maven.apache.org/POM/4.1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 https://maven.apache.org/xsd/maven-4.1.0.xsd">

<parent/>

<artifactId>stormcrawler-aws</artifactId>
<packaging>jar</packaging>
Expand Down
12 changes: 3 additions & 9 deletions external/langid/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,9 @@ specific language governing permissions and limitations
under the License.
-->

<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>org.apache.stormcrawler</groupId>
<artifactId>stormcrawler-external</artifactId>
<version>3.5.1-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>
<project xmlns="http://maven.apache.org/POM/4.1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 https://maven.apache.org/xsd/maven-4.1.0.xsd">

<parent/>

<artifactId>stormcrawler-langid</artifactId>
<packaging>jar</packaging>
Expand Down
87 changes: 41 additions & 46 deletions external/opensearch/archetype/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,54 +19,49 @@ specific language governing permissions and limitations
under the License.
-->

<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<project xmlns="http://maven.apache.org/POM/4.1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 https://maven.apache.org/xsd/maven-4.1.0.xsd">

<parent>
<relativePath>../../..</relativePath>
</parent>

<parent>
<groupId>org.apache.stormcrawler</groupId>
<artifactId>stormcrawler</artifactId>
<version>3.5.1-SNAPSHOT</version>
<relativePath>../../../pom.xml</relativePath>
</parent>
<artifactId>stormcrawler-opensearch-archetype</artifactId>

<packaging>maven-archetype</packaging>

<artifactId>stormcrawler-opensearch-archetype</artifactId>

<packaging>maven-archetype</packaging>
<build>
<resources>
<resource>
<directory>src/main/resources</directory>
<filtering>true</filtering>
<includes>
<include>META-INF/maven/archetype-metadata.xml</include>
</includes>
</resource>
<resource>
<directory>src/main/resources</directory>
<filtering>false</filtering>
<excludes>
<exclude>META-INF/maven/archetype-metadata.xml</exclude>
</excludes>
</resource>
</resources>

<build>
<extensions>
<extension>
<groupId>org.apache.maven.archetype</groupId>
<artifactId>archetype-packaging</artifactId>
<version>3.4.1</version>
</extension>
</extensions>

<resources>
<resource>
<directory>src/main/resources</directory>
<filtering>true</filtering>
<includes>
<include>META-INF/maven/archetype-metadata.xml</include>
</includes>
</resource>
<resource>
<directory>src/main/resources</directory>
<filtering>false</filtering>
<excludes>
<exclude>META-INF/maven/archetype-metadata.xml</exclude>
</excludes>
</resource>
</resources>

<extensions>
<extension>
<groupId>org.apache.maven.archetype</groupId>
<artifactId>archetype-packaging</artifactId>
<version>3.4.1</version>
</extension>
</extensions>

<pluginManagement>
<plugins>
<plugin>
<artifactId>maven-archetype-plugin</artifactId>
<version>3.4.1</version>
</plugin>
</plugins>
</pluginManagement>
</build>
<pluginManagement>
<plugins>
<plugin>
<artifactId>maven-archetype-plugin</artifactId>
<version>3.4.1</version>
</plugin>
</plugins>
</pluginManagement>
</build>
</project>
12 changes: 3 additions & 9 deletions external/opensearch/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,9 @@ specific language governing permissions and limitations
under the License.
-->

<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<project xmlns="http://maven.apache.org/POM/4.1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 https://maven.apache.org/xsd/maven-4.1.0.xsd">

<parent>
<groupId>org.apache.stormcrawler</groupId>
<artifactId>stormcrawler-external</artifactId>
<version>3.5.1-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>
<parent/>

<properties>
<opensearch.version>2.19.4</opensearch.version>
Expand Down Expand Up @@ -110,6 +104,6 @@ under the License.
<artifactId>slf4j-simple</artifactId>
<scope>test</scope>
</dependency>

</dependencies>

</project>
Loading