[SPARK-53789][SQL][CONNECT] Canonicalize error condition CANNOT_MODIFY_STATIC_CONFIG #52506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @MaxGekk |
Member
Author
|
cc @LuciferYang |
LuciferYang
reviewed
Oct 13, 2025
| throw new AnalysisException( | ||
| errorClass = "_LEGACY_ERROR_TEMP_3050", | ||
| messageParameters = Map("k" -> k)) | ||
| throw CompilationErrors.cannotModifyValueOfStaticConfigError(k) |
Contributor
There was a problem hiding this comment.
Why is it necessary to direct users to refer to <docroot>/sql-migration-guide.html#ddl-statements here?
Member
Author
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
Oh, I see your point, here spark.sql.legacy.setCommandRejectsSparkCoreConfs does not take effect, so the docs do not help
pan3793
commented
Oct 13, 2025
| def cannotModifyValueOfStaticConfigError(key: String): Throwable = { | ||
| new AnalysisException( | ||
| errorClass = "CANNOT_MODIFY_STATIC_CONFIG", | ||
| messageParameters = Map("key" -> toSQLConf(key))) |
Member
Author
There was a problem hiding this comment.
@LuciferYang I updated the code to remove the doc link since <docroot>/sql-migration-guide.html#ddl-statements does not provide useful info for this error
LuciferYang
approved these changes
Oct 14, 2025
pan3793
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introduce
CANNOT_MODIFY_STATIC_CONFIGand_LEGACY_ERROR_TEMP_3050toCANNOT_MODIFY_STATIC_CONFIGcannotModifyValueOfStaticConfigErrorfromCANNOT_MODIFY_CONFIG(with suggestion that directs to DDL migration guide) to useCANNOT_MODIFY_STATIC_CONFIGbecause the DDL migration guide does not help for this case.Why are the changes needed?
More consistent error message.
Does this PR introduce any user-facing change?
More consistent error message.
How was this patch tested?
Pass GHA.
Was this patch authored or co-authored using generative AI tooling?
No.