Very basic reading and writing of a raster for InDB #406
Conversation
jesspav
changed the title
jesspav
changed the title
There was a problem hiding this comment.
Pull request overview
This PR introduces foundational support for reading and writing InDB raster data by integrating GDAL into the Sedona-DB project architecture. It provides basic functionality for converting raster files (particularly GeoTIFFs) to and from Sedona's internal raster format.
Key changes:
- Added GDAL dependencies and build system integration
- Implemented raster reading and writing functions for InDB storage
- Created utility functions for data type conversion between GDAL and Sedona formats
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| rust/sedona-raster/src/utils.rs | Added utility functions for byte conversion and data type sizing |
| rust/sedona-raster/src/lib.rs | Exposed the new utils module |
| rust/sedona-gdal/src/raster_io.rs | Implemented core raster I/O functionality with GDAL integration |
| rust/sedona-gdal/src/lib.rs | Created library entry point for GDAL module |
| rust/sedona-gdal/src/dataset.rs | Added dataset metadata extraction utilities |
| rust/sedona-gdal/Cargo.toml | Configured dependencies for GDAL integration |
| Cargo.toml | Added GDAL workspace dependencies and sedona-gdal member |
| .github/workflows/rust.yml | Updated CI to install GDAL development libraries |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| BandDataType::UInt16 => { | ||
| let mut data = Vec::with_capacity(pixel_count); | ||
| for chunk in band_data.chunks_exact(2) { | ||
| data.push(u16::from_ne_bytes([chunk[0], chunk[1]])); |
There was a problem hiding this comment.
The byte-to-type conversion pattern is duplicated across multiple data types (lines 456, 464, 472, 480, 488, 496). Consider extracting this into a helper function to reduce duplication and improve maintainability.
| } | ||
| match data_type { | ||
| BandDataType::UInt8 => Some(bytes[0] as f64), | ||
| BandDataType::UInt16 => Some(u16::from_ne_bytes([bytes[0], bytes[1]]) as f64), |
There was a problem hiding this comment.
The bytes-to-type conversion pattern in bytes_to_f64 duplicates logic from write_band_data. Consider extracting a common conversion function to reduce duplication.
1 participant
This PR introduces foundational support for reading and writing InDB raster data in Sedona-DB, providing the groundwork for future enhancements and expanded functionality.
Key points:
I used this code to generate the 3-band noise raster .tif in #300.
Further iterations and feature expansion are planned to improve usability and extend raster data handling capabilities.