Skip to content

Conversation

dimas-b
Copy link
Contributor

@dimas-b dimas-b commented Oct 21, 2025

Use Apache Ozone as an example S3 impl. that does not have STS.

Comment on lines 112 to 114
chmod +x /assets/polaris/create-catalog.sh;
chmod +x /assets/polaris/obtain-token.sh;
chmod +x /assets/cloud_providers/await-s3.sh;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these script be checked into Git as executable (chmod 755)?
(Out of scope of this PR, but feels better and avoids boilerplate code)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - those scripts already have proper flags.

... but #2878

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chmod removed

Comment on lines +31 to +38
1. Build the Polaris server image if it's not already present locally:

```shell
./gradlew \
:polaris-server:assemble \
:polaris-server:quarkusAppPartsBuild --rerun \
-Dquarkus.container-image.build=true
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image: apache/polaris:latest in the Dockerfile pull latest from Docker Hub, wonder whether this step is really necessary for users.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point... we'll have to wait for 1.2.0 to be published for this to work, though... WDYT? I'm ok waiting.

2. Start the docker compose group by running the following command from the root of the repository:

```shell
docker compose -f getting-started/minio/docker-compose.yml up
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a git clone for posterity, optional though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm... other getting-started READMEs do not do that 🤔 let's keep this example "as is", but I would not mind updating READMEs all together later

--conf spark.sql.catalog.polaris.client.region=irrelevant
```

Note: `s3cr3t` is defined as the password for the `root` users in the `docker-compose.yml` file.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Note: `s3cr3t` is defined as the password for the `root` users in the `docker-compose.yml` file.
Note: `s3cr3t` is defined as the password for the `root` user in the `docker-compose.yml` file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx - fixed (in two places)

Use Apache Ozone as an example S3 impl. that does not have STS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants