-
Notifications
You must be signed in to change notification settings - Fork 320
Add getting started with Apache Ozone #2853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| chmod +x /assets/polaris/create-catalog.sh; | ||
| chmod +x /assets/polaris/obtain-token.sh; | ||
| chmod +x /assets/cloud_providers/await-s3.sh; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't these script be checked into Git as executable (chmod 755)?
(Out of scope of this PR, but feels better and avoids boilerplate code)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch - those scripts already have proper flags.
... but #2878
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chmod removed
| 1. Build the Polaris server image if it's not already present locally: | ||
|
|
||
| ```shell | ||
| ./gradlew \ | ||
| :polaris-server:assemble \ | ||
| :polaris-server:quarkusAppPartsBuild --rerun \ | ||
| -Dquarkus.container-image.build=true | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
image: apache/polaris:latest in the Dockerfile pull latest from Docker Hub, wonder whether this step is really necessary for users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point... we'll have to wait for 1.2.0 to be published for this to work, though... WDYT? I'm ok waiting.
| 2. Start the docker compose group by running the following command from the root of the repository: | ||
|
|
||
| ```shell | ||
| docker compose -f getting-started/minio/docker-compose.yml up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a git clone for posterity, optional though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm... other getting-started READMEs do not do that 🤔 let's keep this example "as is", but I would not mind updating READMEs all together later
getting-started/ozone/README.md
Outdated
| --conf spark.sql.catalog.polaris.client.region=irrelevant | ||
| ``` | ||
|
|
||
| Note: `s3cr3t` is defined as the password for the `root` users in the `docker-compose.yml` file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Note: `s3cr3t` is defined as the password for the `root` users in the `docker-compose.yml` file. | |
| Note: `s3cr3t` is defined as the password for the `root` user in the `docker-compose.yml` file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx - fixed (in two places)
b742abb to
dbde13a
Compare
Use Apache Ozone as an example S3 impl. that does not have STS.
dbde13a to
a4202b9
Compare
Use Apache Ozone as an example S3 impl. that does not have STS.