Python: Fix client generation #2797
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyrain
previously approved these changes
Oct 12, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
flyrain
reviewed
Oct 13, 2025
HonahX
reviewed
Oct 13, 2025
| # generate the management api client | ||
| docker run --rm \ | ||
| -v ${PWD}:/local openapitools/openapi-generator-cli generate \ | ||
| -v ${PWD}:/local openapitools/openapi-generator-cli:v7.9.0 generate \ |
There was a problem hiding this comment.
I think we could delete this part, now the python client will auto-generate all the client using the latest spec file upon build, so we do not need to run these manually anymore : )
There was a problem hiding this comment.
Yes. this happened with 7.13 (first breaking version as it needs 3.1.1). In this PR #2800, I bumped it to the latest working version. When running regtests via make, this will be done automatically (as part of polaris package install/build)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix for python client generation for regtests
Why are the changes needed?
unable to build client without this change, this force the open-api generator to a version which ignores example empty
Does this PR introduce any user-facing change?
No
How was this patch tested?
Error above is gone
CHANGELOG.md
May be not