PHOENIX-7566 Returning waitTime as part of state transition response (#2314) #2350
+134
−112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently during transition from ANIS -> AIS (i.e. Store&Forward to Sync mode), we have a wait time to ensure that no RS has reported itself in ANIS state in last zkTimeout time. If ReplicationLogGroupWriter calls the HAGroupStoreManager during this wait time, the update is ignored and no response is sent back to ReplicationLogGroupWriter. This change is to send the remaining wait time back to caller(in this case ReplicationLogGroupWriter). To keep it consistent for all such changes and avoid users to have to update in future, updating this behavior for all setState methods in HAGroupStoreManager.
Testing
Updated ITs for checking if value returned is > 0 for cases when expected and 0 when update should go through to ZK.