[flink] Don't reopen the dim table if the scanned partitions are not overwritten #6596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
Nov 14, 2025
| private final StartupMode startupMode; | ||
| private final LookupStreamScanMode lookupScanMode; | ||
|
|
||
| private List<BinaryRow> scanPartitions = Collections.emptyList(); |
JingsongLi
reviewed
Nov 14, 2025
| } | ||
|
|
||
| private boolean shouldReopen(Snapshot snapshot) { | ||
| if (scanPartitions.isEmpty()) { |
Contributor
There was a problem hiding this comment.
if scan partitions is null
yuzelin
force-pushed
the
refactor-dim-overwrite
branch
from
679b63f to
2a24946
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
For example, lookup with scan MAX_PT(), and the current MAX_PT is 20251111. If overwrite pt 20241110, we don't need to reopen the dim table.
Tests
API and Format
Documentation