[core] format table: insert data after commit sync partitions to hms #6584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it_sync_hms * upstream/master: [core] format table: fix partition key not in the end write error (apache#6595) [core] Async snapshot expire fallback to sync mode in batch commit (apache#6593) [spark] Enable dynamic options for format table (apache#6592) [arrow] Fix that complex writers didn't reset inner writer state (apache#6591)
JingsongLi
reviewed
Nov 14, 2025
| .stringType() | ||
| .noDefaultValue() | ||
| .withDescription("Format table commit sync partition hive uri."); | ||
| public static final ConfigOption<String> FORMAT_TABLE_COMMIT_SYNC_PARTITION_HIVE_WAREHOUSE = |
Contributor
There was a problem hiding this comment.
warehouse is useless, remove it.
JingsongLi
reviewed
Nov 17, 2025
| <td>Whether to force the use of lookup for compaction.</td> | ||
| </tr> | ||
| <tr> | ||
| <td><h5>format-table.commit.sync-partition-hive.uri</h5></td> |
Contributor
There was a problem hiding this comment.
format-table.commit-hive-sync-url.
JingsongLi
reviewed
Nov 17, 2025
|
|
||
| if (options.type() == TableType.FORMAT_TABLE) { | ||
| return toFormatTable(identifier, schema, dataFileIO); | ||
| return toFormatTable(identifier, schema, dataFileIO, catalog.catalogContext()); |
Contributor
There was a problem hiding this comment.
Already has parameter catalogContext...
JingsongLi
reviewed
Nov 17, 2025
Contributor
JingsongLi
left a comment
JingsongLi
left a comment
There was a problem hiding this comment.
Can you also add a test for this? In Spark FormatTableTestBase.
jerry-024
force-pushed
the
format_table_commit_sync_hms
branch
from
ccddcf3 to
834a0e0
Compare
jerry-024
force-pushed
the
format_table_commit_sync_hms
branch
from
e7705fc to
6bf2b94
Compare
…it_sync_hms * upstream/master: [core] Fix the serialization of JindoMultiPartUploadCommitter (apache#6613) [core] Postpone mode should not mark done when still has compaction (apache#6561) [spark] Wrap the corresponding table to ensure it guarantees its capabilities (apache#6607)
jerry-024
force-pushed
the
format_table_commit_sync_hms
branch
from
60faa2f to
42f83f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
format table: insert data after commit sync partitions to hms
format-table.commit-hive-sync-urlto support sync partition to hms.Tests
API and Format
Documentation