-
Notifications
You must be signed in to change notification settings - Fork 913
Upgrade nb-javac to JDK 26b26 #9044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
the (unrelated) refactoring generates: private final transient_or_acc_varargs PropertyChangeSupport propertyChangeSupport = new java.beans.PropertyChangeSupport(this);instead of: private final transient PropertyChangeSupport propertyChangeSupport = new java.beans.PropertyChangeSupport(this);sounds like a change in a edit: fixed |
....editor.base/src/org/netbeans/modules/java/editor/base/semantic/SemanticHighlighterBase.java
Outdated
Show resolved
Hide resolved
…c after the JDK 26 upgrade.
| matrix: | ||
| java: [ '17', '25' ] | ||
| java: [ '17', '25', '26-ea' ] | ||
| config: [ 'batch1', 'batch2' ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note to self: probably better to reduce the matrix to upper/lower bound, otherwise this job would cause too many manual restarts when both batches run three times.
Upgrades the javac integration to nb-javac based on JDK 26b26.
This PR is based on a copy of the valhalla javac experiment #8995 but swaps the nb-javac dependency against staged nb-javac 26b26 based on https://github.com/lahodaj/nb-javac/commits/upgrade-jdk26/. It will be later updated to a nb-javac release from maven central.
manual testing:
closes #4470
closes #6822
closes #8722