[KYUUBI #7133] Use stmtHandleChangeLock in KyuubiStatement to ensure thread safe access and updates to stmtHandle.

[ruanwenjun]

Why are the changes needed?

The check for null and the subsequent use or assignment of the stmtHandle is not an atomic operation, might cause the stmt doesn't be closed.

How was this patch tested?

UT.

Was this patch authored or co-authored using generative AI tooling?

NO.

[pan3793]

I think you should check isCancelled again after obtaining the lock

[ruanwenjun]

Good catch. I’ve moved the check after stmtHandleChangeLock.lock() — this should look good now.

[pan3793]

CI is fixed on master, you can rebase the PR to recover the CI.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 0% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (a1a08e7) to head (ce54a5d).
⚠️ Report is 15 commits behind head on master.

Files with missing lines	Patch %	Lines
...a/org/apache/kyuubi/jdbc/hive/KyuubiStatement.java	0.00%	44 Missing ⚠️
.../org/apache/kyuubi/jdbc/hive/KyuubiConnection.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@          Coverage Diff           @@
##           master   #7134   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         700     701    +1     
  Lines       43454   43506   +52     
  Branches     5883    5896   +13     
======================================
- Misses      43454   43506   +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull Request Overview

This PR introduces thread-safety controls around the statement handle in KyuubiStatement and adds a concurrent unit test to verify behavior when closing and executing simultaneously.

• Added a ReentrantLock (stmtHandleAccessLock) and made stmtHandle, isClosed, and isCancelled volatile to prevent race conditions.
• Wrapped cancel(), close(), and runAsyncOnServer(...) in locks to ensure atomic checks and updates.
• Added a multithreaded test (testThrowKyuubiSQLExceptionWhenExecuteSqlOnClosedStmt) in KyuubiStatementTest to assert proper exception on execute after close.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiStatement.java	Introduced stmtHandleAccessLock and volatile flags; applied locking in key methods to ensure thread safety.
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiConnection.java	Made the isClosed flag volatile for safe concurrent reads.
kyuubi-hive-jdbc/src/test/java/org/apache/kyuubi/jdbc/hive/KyuubiStatementTest.java	Added a concurrent test to validate exception is thrown when executing after close.