KAFKA-19724: Global stream thread should not ignore any exceptions #20668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celikfatih
changed the title
mjsax
changed the title
mjsax
approved these changes
Oct 15, 2025
Member
mjsax
left a comment
mjsax
left a comment
There was a problem hiding this comment.
Thanks for the PR. Overall LGTM. One nit about naming.
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStreamThread.java
Outdated
Show resolved
Hide resolved
mjsax
pushed a commit
that referenced
this pull request
Oct 17, 2025
…20668) Kafka Streams does not catch Error types that occur during `GlobalStreamThread` initiation, and therefore it is not possible to trace the error (for example, an `ExceptionInInitializerError` occurs when RocksDB is not found for a global store). This is because errors are not caught and logged. The catch block in `GlobalStreamThread#initialize()` has been ensured to catch `Throwable` instead of `Exception`. Additionally, the empty `setUncaughtHandler` set operation that prevented this from taking effect when users employed setUncaughtExceptionHandler has been removed. Reviewers: Matthias J. Sax <[email protected]>
mjsax
pushed a commit
that referenced
this pull request
Oct 17, 2025
…20668) Kafka Streams does not catch Error types that occur during `GlobalStreamThread` initiation, and therefore it is not possible to trace the error (for example, an `ExceptionInInitializerError` occurs when RocksDB is not found for a global store). This is because errors are not caught and logged. The catch block in `GlobalStreamThread#initialize()` has been ensured to catch `Throwable` instead of `Exception`. Additionally, the empty `setUncaughtHandler` set operation that prevented this from taking effect when users employed setUncaughtExceptionHandler has been removed. Reviewers: Matthias J. Sax <[email protected]>
Member
|
Thanks for the fix! Merged to |
mjsax
pushed a commit
that referenced
this pull request
Oct 17, 2025
…20668) Kafka Streams does not catch Error types that occur during `GlobalStreamThread` initiation, and therefore it is not possible to trace the error (for example, an `ExceptionInInitializerError` occurs when RocksDB is not found for a global store). This is because errors are not caught and logged. The catch block in `GlobalStreamThread#initialize()` has been ensured to catch `Throwable` instead of `Exception`. Additionally, the empty `setUncaughtHandler` set operation that prevented this from taking effect when users employed setUncaughtExceptionHandler has been removed. Reviewers: Matthias J. Sax <[email protected]>
eduwercamacaro
pushed a commit
to littlehorse-enterprises/kafka
that referenced
this pull request
Nov 12, 2025
…pache#20668) Kafka Streams does not catch Error types that occur during `GlobalStreamThread` initiation, and therefore it is not possible to trace the error (for example, an `ExceptionInInitializerError` occurs when RocksDB is not found for a global store). This is because errors are not caught and logged. The catch block in `GlobalStreamThread#initialize()` has been ensured to catch `Throwable` instead of `Exception`. Additionally, the empty `setUncaughtHandler` set operation that prevented this from taking effect when users employed setUncaughtExceptionHandler has been removed. Reviewers: Matthias J. Sax <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kafka Streams does not catch Error types that occur during
GlobalStreamThreadinitiation, and therefore it is not possible totrace the error (for example, an
ExceptionInInitializerErroroccurswhen RocksDB is not found for a global store). This is because errors
are not caught and logged.
The catch block in
GlobalStreamThread#initialize()has been ensured tocatch
Throwableinstead ofException. Additionally, the emptysetUncaughtHandlerset operation that prevented this from takingeffect when users employed setUncaughtExceptionHandler has been removed.
Reviewers: Matthias J. Sax [email protected]