MINOR: ignore result of "missing build scan" #20659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
Member
|
@Yunyung could you please revert previous failed approach? |
Collaborator
Author
|
Sure. Revert the failed approach from #20644 in latest comimt. |
chia7712
reviewed
Oct 8, 2025
.github/workflows/ci-complete.yml
Outdated
| description: 'Could not find build scan' | ||
| context: Gradle Build Scan / ${{ env.status-context }} | ||
| state: 'error' | ||
| state: 'success' # WAR: Mark as successful, not show as failing, for those branches without the KAFKA-18748 patches |
Member
There was a problem hiding this comment.
KAFKA-18748 is not the only reason. The other cause is the difference in supported JDKs. For example, trunk now supports JDK 25, but the 4.1 branch does not
Member
|
@mumrah What do you think? I want to use a simple fix to eliminate the build errors on the 4.1 and 4.0 branches. We can discuss rewriting |
mumrah
approved these changes
Oct 13, 2025
.github/workflows/ci-complete.yml
Outdated
| description: 'Could not find build scan' | ||
| context: Gradle Build Scan / ${{ env.status-context }} | ||
| state: 'error' | ||
| state: 'success' # WAR: Always mark as successful, not as failing, for non-trunk branches; real solution to follow in KAFKA-19768 |
Member
There was a problem hiding this comment.
nit: "WAR" i assume means workaround, but isn't really clear. I would just have the comment reference the JIRA and explain why we're doing this for now
Collaborator
Author
|
Thanks for the review! Addressed the comment. |
chia7712
approved these changes
Oct 16, 2025
eduwercamacaro
pushed a commit
to littlehorse-enterprises/kafka
that referenced
this pull request
Nov 12, 2025
Always mark the result of "missing build scan" as successful, not as failing, for 4.0 and 4.1. Two reasons causing missing build scan: - 4.0 does not have the KAFKA-18748 patches. - The JDK version used by `ci-complete` is inconsistent with other active branches, causing the build report task to fail. The real solution will be in [KAFKA-19768](https://issues.apache.org/jira/browse/KAFKA-19768). Reviewers: David Arthur <[email protected]>, Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always mark the result of "missing build scan" as successful, not as
failing, for 4.0 and 4.1.
Two reasons causing missing build scan:
ci-completeis inconsistent with otheractive branches, causing the build report task to fail.
The real solution will be in
KAFKA-19768.
Reviewers: David Arthur [email protected], Chia-Ping Tsai
[email protected]