Skip to content

MINOR: build dependecies - version updates #20656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2025
Merged

MINOR: build dependecies - version updates #20656

merged 1 commit into from
Oct 16, 2025

Conversation

@dejan2609
Copy link
Contributor

@dejan2609 dejan2609 commented Oct 7, 2025 •
edited by github-actions bot
Loading

Extends from: #19513

details:

  • scala-logging_2.13: Updated from 3.9.5 to 3.9.6
  • org.owasp.dependencycheck: Updated from 12.1.3 to 12.1.8
  • org.scoverage: Updated from 8.0.3 to 8.1
  • com.diffplug.spotless: Updated from 7.2.1 to 8.0.0
  • scalafmt: Updated from 3.7.14 to 3.10.0
  • grgit: Updated from 4.1.1 to 5.3.3
  • jacoco: Updated from 0.8.13 to 0.8.14
  • scoverage: Updated from 2.0.11 to 2.3.0

Reviewers: Chia-Ping Tsai [email protected]

@github-actions github-actions bot added triage PRs from the community build Gradle build or GitHub Actions small Small PRs labels Oct 7, 2025
@chia7712
Copy link
Member

chia7712 commented Oct 8, 2025

@dejan2609 would you mind filing a PR to update all those dependencies?

@dejan2609
Copy link
Contributor Author

dejan2609 commented Oct 8, 2025

Yes, that is doable 🔧

@chia7712
Copy link
Member

chia7712 commented Oct 8, 2025

Yes, that is doable

I will merge #20652 first. Please update this PR with the necessary dependencies updates once that is done! thanks

@dejan2609 dejan2609 changed the title MINOR: Scala coverage: version update MINOR: build dependecies - version updates Oct 8, 2025
@dejan2609 dejan2609 force-pushed the scala-coverage-version-update branch from a42860a to 91c0595 Compare October 8, 2025 08:06
@dejan2609
Copy link
Contributor Author

dejan2609 commented Oct 8, 2025

@chia7712 PR is ready for review.

@dejan2609
Copy link
Contributor Author

dejan2609 commented Oct 8, 2025

I will rebase onto trunk to pick up Java 25 build solution that was merged moments ago 🍀

@dejan2609 dejan2609 force-pushed the scala-coverage-version-update branch from 91c0595 to d28b9a3 Compare October 8, 2025 08:26
@dejan2609
Copy link
Contributor Author

dejan2609 commented Oct 8, 2025

@chia7712 Test results are fine - only two unrelated tests failed (and for Java 17 build only) ✅

@dejan2609
Copy link
Contributor Author

dejan2609 commented Oct 8, 2025

Hold on - I will include scala logging also: https://central.sonatype.com/artifact/com.typesafe.scala-logging/scala-logging_2.13/3.9.6

@dejan2609 dejan2609 marked this pull request as draft October 8, 2025 11:02
@dejan2609 dejan2609 marked this pull request as ready for review October 8, 2025 11:10
@dejan2609 dejan2609 force-pushed the scala-coverage-version-update branch from d28b9a3 to c6cbfec Compare October 8, 2025 11:10
@dejan2609
Copy link
Contributor Author

dejan2609 commented Oct 8, 2025

Another commit will be force-pushed to solve this:
image

@dejan2609 dejan2609 force-pushed the scala-coverage-version-update branch from c6cbfec to 3f30f7b Compare October 8, 2025 12:36
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Oct 8, 2025
@dejan2609
Copy link
Contributor Author

dejan2609 commented Oct 8, 2025 •
edited
Loading

@chia7712 this is (finally) ready for a review 🔎

chia7712
chia7712 reviewed Oct 8, 2025
View reviewed changes
@dejan2609 dejan2609 requested a review from chia7712 October 8, 2025 18:17
@github-actions github-actions bot removed the triage PRs from the community label Oct 9, 2025
chia7712
chia7712 reviewed Oct 9, 2025
View reviewed changes
@dejan2609 dejan2609 force-pushed the scala-coverage-version-update branch from 9a2d85d to ca4ec09 Compare October 9, 2025 20:16
@dejan2609 dejan2609 requested a review from chia7712 October 9, 2025 20:18
@chia7712
Copy link
Member

chia7712 commented Oct 10, 2025

It seems the JDkK 17 build keeps failing. I have triggered it again, so let's see what happens

@dejan2609
Copy link
Contributor Author

dejan2609 commented Oct 10, 2025

@chia7712 all in green now 🍀

@dejan2609
Copy link
Contributor Author

dejan2609 commented Oct 10, 2025 •
edited
Loading

@chia7712 I opt to bundle #20683 (--no-parallel switch for aggregatedJavadoc) here.
It really makes sense: both things are echoing Gradle 8 to 9 upgrade.

@dejan2609 dejan2609 mentioned this pull request Oct 10, 2025
Merged
@dejan2609 dejan2609 force-pushed the scala-coverage-version-update branch from 8dc2fb3 to ca4ec09 Compare October 10, 2025 17:33
@dejan2609
Copy link
Contributor Author

dejan2609 commented Oct 11, 2025

@chia7712 all in green now 🟢 🍀 ✅

@dejan2609
Copy link
Contributor Author

dejan2609 commented Oct 13, 2025

📓 Note: org.owasp.dependencycheck plugin version 12.1.7 has been released: https://github.com/dependency-check/DependencyCheck/blob/v12.1.7/CHANGELOG.md

I'll rebase this PR.

@dejan2609 dejan2609 force-pushed the scala-coverage-version-update branch from ca4ec09 to 8a8b680 Compare October 13, 2025 14:41
@dejan2609 dejan2609 force-pushed the scala-coverage-version-update branch from 8a8b680 to 2093b9d Compare October 15, 2025 11:46
@dejan2609
Copy link
Contributor Author

dejan2609 commented Oct 15, 2025 •
edited
Loading

Rebased and force-pushed: org.owasp.dependencycheck gradle plugin just published another version (12.1.8).

@chia7712
Copy link
Member

chia7712 commented Oct 15, 2025

@dejan2609 could you please update swagger, checkstyle, spotbugs, jacoco and scoverage, which are used by build.gradle

@dejan2609
Copy link
Contributor Author

dejan2609 commented Oct 15, 2025

Sure, let me check those.

From the top of my head: I think that swagger can't be upgraded to the latest version easily (but will double-check that).

@dejan2609
Copy link
Contributor Author

dejan2609 commented Oct 15, 2025

@chia7712

Here is the list related to the version changes mentioned above:

  • swagger: even patch version update is not a trivial task -->> KAFKA-19792
  • checkstyle: upgrade from 10.20.2 -->> 12.0.1 is possible, but around 20 or so classes have to be changed all along (indentation, etc.); I assume that a separate PR for this would be a good idea (I can bundle those changes here, but it will take a few days)
  • spotbugs: solved elsewhere 🙂 -->> KAFKA-19771 Update SpotBugs version and enable Spotbugs Gradle tasks on Java 25 #20704
  • jacoco: version update 0.8.13 -->> 0.8.14 will be added into this PR
  • scala coverage: all latest versions (scoverage / scalac-scoverage-plugin / scoverage gradle plugin) are/were already included here

@dejan2609 dejan2609 force-pushed the scala-coverage-version-update branch from 2093b9d to 59874c6 Compare October 15, 2025 18:26
@dejan2609
Copy link
Contributor Author

dejan2609 commented Oct 15, 2025

And I just realized that Scala formatter 3.10.0 (tested against Scala 2.13.17) has just been published: https://github.com/scalameta/scalafmt/releases/tag/v3.10.0 😃

Ok, I'll bump it ⬆️

@dejan2609
MINOR: build dependecies - version updates
e11ac64 
details:
 - `grgit`: 4.1.1 -->> 5.3.3
 - `jacoco`: 0.8.13 -->> 0.8.14
 - `scala-logging`: 3.9.5 -->> 3.9.6
 - `scalafmt`: 3.7.14 -->> 3.10.0
 - `org.owasp.dependencycheck` gradle plugin: 12.1.3 -->> 12.1.8
 - `com.diffplug.spotless` gradle plugin: 7.2.1 -->> 8.0.0
 - Scala coverage:
   - scoverage: 2.0.11 -->> 2.3.0
   - Scala version for scoverage: 2.13.9 -->> 2.13.16 (i.e. `org.scoverage:scalac-scoverage-plugin_2.13.16:2.3.0` will be used)
   - `org.scoverage` gradle plugin: 8.0.3 -->> 8.1
@dejan2609 dejan2609 force-pushed the scala-coverage-version-update branch from 59874c6 to e11ac64 Compare October 15, 2025 20:31
@dejan2609
Copy link
Contributor Author

dejan2609 commented Oct 15, 2025

Done. I checked (with ./gradlew dependencyUpdates --no-parallel) and it seems there's nothing left.

@dejan2609 dejan2609 requested a review from chia7712 October 16, 2025 05:45
@chia7712 chia7712 merged commit abee765 into apache:trunk Oct 16, 2025
20 of 22 checks passed
@dejan2609 dejan2609 deleted the scala-coverage-version-update branch October 16, 2025 17:46
eduwercamacaro pushed a commit to littlehorse-enterprises/kafka that referenced this pull request Nov 12, 2025
@dejan2609 @eduwercamacaro
MINOR: build dependecies - version updates (apache#20656)
2cf50cd 
Extends from: apache#19513

details:
- scala-logging_2.13: Updated from 3.9.5 to 3.9.6
- org.owasp.dependencycheck: Updated from 12.1.3 to 12.1.8
- org.scoverage: Updated from 8.0.3 to 8.1
- com.diffplug.spotless: Updated from 7.2.1 to 8.0.0
- scalafmt: Updated from 3.7.14 to 3.10.0
- grgit: Updated from 4.1.1 to 5.3.3
- jacoco: Updated from 0.8.13 to 0.8.14
- scoverage: Updated from 2.0.11 to 2.3.0

Reviewers: Chia-Ping Tsai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chia7712 chia7712 Awaiting requested review from chia7712

Assignees

No one assigned

Labels

build Gradle build or GitHub Actions ci-approved dependencies Pull requests that update a dependency file small Small PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dejan2609 @chia7712