[xtable-utilities] Remove duplicate AWS SDK v2 modules from shaded jar - #923
Open
abdul-traya wants to merge 2 commits into
Open
[xtable-utilities] Remove duplicate AWS SDK v2 modules from shaded jar#923abdul-traya wants to merge 2 commits into
abdul-traya wants to merge 2 commits into
Conversation
software.amazon.awssdk:bundle already contains internally-consistent copies of regions/sdk-core/utils. Including them separately in the shade artifactSet caused the shade plugin to merge two different builds of these classes, so the bundle's STS classes (needed for IRSA/web-identity credentials on EKS) ended up paired with an IoUtils class missing a method they call -- NoSuchMethodError at JVM shutdown when closing the STS web-identity credentials provider.
…bundle The first pass only removed regions/sdk-core/utils, which fixed one NoSuchMethodError but exposed another (auth's LazyAwsCredentialsProvider paired with a mismatched IoUtils again) since auth/aws-core/glue/apache-client /netty-nio-client/etc were still separately included alongside bundle. bundle already contains internally-consistent copies of every individual software.amazon.awssdk:* module, so keep only it -- verified via javap that LazyAwsCredentialsProvider.close()'s IoUtils.closeIfCloseable call now resolves against a matching overload in the rebuilt jar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
software.amazon.awssdk:bundle already contains internally-consistent copies of regions/sdk-core/utils. Including them separately in the shade artifactSet caused the shade plugin to merge two different builds of these classes, so the bundle's STS classes (needed for IRSA/web-identity credentials on EKS) ended up paired with an IoUtils class missing a method they call -- NoSuchMethodError at JVM shutdown when closing the STS web-identity credentials provider.
Important Read
What is the purpose of the pull request
(For example: This pull request implements the sync for delta format.)
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)