fix(CI): Fix Ubuntu 20.04 with OpenSSL 3 installed: undefined reference to ERR_peek_last_error_all#2342
Open
Samunroyu wants to merge 3 commits intoapache:masterfrom
Open
fix(CI): Fix Ubuntu 20.04 with OpenSSL 3 installed: undefined reference to ERR_peek_last_error_all#2342Samunroyu wants to merge 3 commits intoapache:masterfrom
Samunroyu wants to merge 3 commits intoapache:masterfrom
Conversation
…ce to ERR_peek_last_error_all
acelyc111-bot
left a comment
There was a problem hiding this comment.
Review: Fix Ubuntu 20.04 with OpenSSL 3 build issues
Summary: Fixes Docker build failures on Ubuntu 20.04 when OpenSSL 3 is installed by adding proper symlinks for shared libraries and setting environment variables for CMake/pkg-config/ld.
What's good:
- Symlinks
libssl.so.3andlibcrypto.so.3into system library path — this is the key fix for the "undefined reference" errors - Proper env vars set (
CMAKE_PREFIX_PATH,PKG_CONFIG_PATH,LD_LIBRARY_PATH,LIBRARY_PATH,CPATH) so downstream tools can find OpenSSL 3 - Multi-stage build pattern (
stage-${OS_VERSION}) allows OS-specific config without duplication - Copies headers to
/usr/include/openssl/for compatibility with projects expecting system paths
Minor notes:
ldconfig -vchanged toldconfig— removes verbose output from build logs, good call- The multi-stage approach is clean but the intermediate stages (
stage-rockylinux9,stage-ubuntu2204,stage-ubuntu1804) are just pass-throughs — consider adding a comment explaining they're placeholders for future OS-specific configs
Verdict: ✅ Approve — Correct fix for a real build blocker. Ready to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2340
Different OS Versions are using the same thirdparty-bin-src images. We need to set ENV in DockerFile when OS Version is ubuntu 2004. And avoiding ENV affect other OS.