test(bdd): fail Go BDD runner on undefined steps#3681
Open
seokjin0414 wants to merge 1 commit into
Open
Conversation
|
Thanks for the PR. It is labeled Slash commands (own line, regular comment) move it around the queue:
See CONTRIBUTING.md for details. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3681 +/- ##
=========================================
Coverage 73.99% 73.99%
Complexity 937 937
=========================================
Files 1301 1301
Lines 147393 147393
Branches 122945 122945
=========================================
Hits 109063 109063
Misses 34858 34858
Partials 3472 3472
🚀 New features to boost your workflow:
|
godog is non-strict by default, so a step in a shared feature file with no matching definition in the Go runner is reported as undefined while the suite still exits 0 and CI stays green. Set Strict on both suites so undefined steps fail the run. Refs apache#3634 Signed-off-by: shin <sars21@hanmail.net>
seokjin0414
force-pushed
the
3634-bdd-strict-go
branch
from
July 17, 2026 11:14
e0452db to
da1d7b4
Compare
Contributor
Author
hubcio
approved these changes
Jul 17, 2026
numinnex
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3554 — Go half of #3634 (Rust half in #3680).
godog is non-strict by default and neither
godog.Optionsblock setStrict, so a step without a matching definition in the Go runner is reported as undefined whilego teststill exits 0 and CI stays green. Both suites now setStrict: true; the existings.Run() != 0check turns that into a test failure.Verification (local server with
--with-default-root-credentials, fresh data dir per run):BDD_FEATURE=basic_messaging go test -count=1 ./tests/→ exit 0,17 steps (17 passed)1 scenarios (1 undefined)→ FAILgofmt/go vetcleanRefs #3634