Skip to content

test(bdd): fail Go BDD runner on undefined steps#3681

Open
seokjin0414 wants to merge 1 commit into
apache:masterfrom
seokjin0414:3634-bdd-strict-go
Open

test(bdd): fail Go BDD runner on undefined steps#3681
seokjin0414 wants to merge 1 commit into
apache:masterfrom
seokjin0414:3634-bdd-strict-go

Conversation

@seokjin0414

Copy link
Copy Markdown
Contributor

Follow-up to #3554 — Go half of #3634 (Rust half in #3680).

godog is non-strict by default and neither godog.Options block set Strict, so a step without a matching definition in the Go runner is reported as undefined while go test still exits 0 and CI stays green. Both suites now set Strict: true; the existing s.Run() != 0 check turns that into a test failure.

Verification (local server with --with-default-root-credentials, fresh data dir per run):

Refs #3634

@github-actions

Copy link
Copy Markdown

Thanks for the PR. It is labeled S-waiting-on-review and queued for review.

Slash commands (own line, regular comment) move it around the queue:

  • /ready - back to S-waiting-on-review after addressing feedback
  • /author - flip to S-waiting-on-author while you finish changes
  • /request-review @user-or-team - request a reviewer

See CONTRIBUTING.md for details.

@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label Jul 16, 2026
@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.99%. Comparing base (6f1d548) to head (da1d7b4).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3681   +/-   ##
=========================================
  Coverage     73.99%   73.99%           
  Complexity      937      937           
=========================================
  Files          1301     1301           
  Lines        147393   147393           
  Branches     122945   122945           
=========================================
  Hits         109063   109063           
  Misses        34858    34858           
  Partials       3472     3472           
Components Coverage Δ
Rust Core 74.29% <ø> (ø)
Java SDK 62.44% <ø> (ø)
C# SDK 72.18% <ø> (ø)
Python SDK 92.17% <ø> (ø)
PHP SDK 84.29% <ø> (ø)
Node SDK 91.26% <ø> (ø)
Go SDK 42.87% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

godog is non-strict by default, so a step in a shared feature file
with no matching definition in the Go runner is reported as undefined
while the suite still exits 0 and CI stays green. Set Strict on both
suites so undefined steps fail the run.

Refs apache#3634

Signed-off-by: shin <sars21@hanmail.net>
@seokjin0414

Copy link
Copy Markdown
Contributor Author

@hubcio could you take a look at this one as well? go half of #3634, same fix as the rust one (#3680) you approved — 2-line diff. CI is re-running after a rebase onto latest master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review PR is waiting on a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants